Mapillary plugin fails to download tiles with URISyntaxException

[AntiCompositeNumber]

What steps will reproduce the problem?

1. Open Mapillary layer (traffic signs and point features layers are also broken) on Java 17 on Arch Linux

What is the expected result?

Mapillary data

What happens instead?

java.io.IOException: java.net.URISyntaxException: Illegal character in query at index 89: https://tiles.mapillary.com/maps/vtp/mly1_computed_public/2/14/4963/6021?access_token=MLY|****************|********************************. Cause: java.net.URISyntaxException: Illegal character in query at index 89: https://tiles.mapillary.com/maps/vtp/mly1_computed_public/2/14/4963/6021?access_token=MLY|****************|********************************

Please provide any additional information below. Attach a screenshot if possible.

index 89 in the URL is |. Seems like a URL encoding problem.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-05-17 23:01:34 +0200 (Wed, 17 May 2023)
Revision:18732
Build-Date:2023-05-19 01:31:00
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18732 en) Linux Arch Linux
Memory Usage: 948 MB / 3912 MB (294 MB allocated, but free)
Java version: 17.0.7+7, N/A, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarkLaf
Screen: :0.0 1920×1080 (scaling 1.00×1.00) :0.1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: i3
VM arguments: [--add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, -Djosm.restart=true, -Dawt.useSystemAAFontSettings=gasp]

Plugins:
+ AddrInterpolation (36079)
+ Create_grid_of_ways (36066)
+ FastDraw (36066)
+ HouseNumberTaggingTool (36079)
+ ImportImagePlugin (36013)
+ MakeParallel (v1.1.0)
+ Mapillary (2.1.3)
+ OpeningHoursEditor (36079)
+ QuickLabel (23)
+ RoadSigns (36066)
+ SeaChart (35840)
+ ShapeTools (1250)
+ alignways (36079)
+ apache-commons (36034)
+ apache-http (35924)
+ auto_tools (81)
+ buildings_tools (36011)
+ changeset-viewer (0.0.6)
+ conflation (0.6.11)
+ continuosDownload (1.3.4)
+ contourmerge (v0.1.9)
+ easypresets (1623509627)
+ editgpx (36079)
+ ejml (35924)
+ flatlaf (36036)
+ geotools (36068)
+ gridify (1606242219)
+ http2 (35921)
+ intersection (0.0.7)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jogl (1.2.3)
+ jts (36004)
+ livegps (36031)
+ log4j (36045)
+ mapwithai (794)
+ measurement (36066)
+ microdata_scraping (1608227152)
+ notesolver (0.5.0)
+ opendata (36079)
+ openqa (v0.3.3)
+ photo_geotagging (36079)
+ photoadjust (36079)
+ pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT)
+ public_transport (36079)
+ reverter (36066)
+ shrinkwrap (v1.0.4)
+ tageditor (36079)
+ terracer (36079)
+ todo (123)
+ touchscreenhelper (35893)
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36079)
+ undelete (36066)
+ utilsplugin2 (36079)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-stops&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/US.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-highways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1
+ <josm.userdata>/EasyPresets.xml
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_AME.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://raw.githubusercontent.com/yopaseopor/indoormap/master/indoormap-style.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Building_Levels_Labels&zip=1
- https://raw.githubusercontent.com/OpenSidewalks/OpenSidewalks-Schema/master/open_sidewalks.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/TreeCrownDiameter&zip=1
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/TigerReviewedNo&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/FixmeAndNote&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Direction&zip=1

Last errors/warnings:
- 00017.185 W: Not a single layer for the name 'NOAA Hampton': []
- 00023.807 E: Failed to locate image 'traffic_signs/US/US_W14-1.png'
- 00023.808 W:  null: Could not get presets icon traffic_signs/US/US_W14-1.png
- 00023.813 E: Failed to locate image 'traffic_signs_presets/crossing.svg'
- 00023.814 W:  null: Could not get presets icon traffic_signs_presets/crossing.svg
- 00023.820 E: Failed to locate image 'traffic_signs/US/US_W14-1.png'
- 00023.821 W:  noexit: Could not get presets icon traffic_signs/US/US_W14-1.png
- 00023.822 E: Failed to locate image 'traffic_signs_presets/crossing.svg'
- 00023.822 W:  PEA Crossing: Could not get presets icon traffic_signs_presets/crossing.svg
- 00040.192 E: Failed to locate image 'https://prd-wret.s3.us-west-2.amazonaws.com/assets/palladium/production/s3fs-public/styles/content_list_thumbnail/public/thumbnails/image/USGS_logo_green_SQUARE.png'

[taylor.smock]

+ http2 (35921)

It looks like this is due to the http2 plugin. I'll see if I can figure out how to fix it on the Mapillary end, since the http2 plugin will eventually be moved into JOSM core. I probably just have to URL encode |.

[taylor.smock]

I've got a fix. It should land in the next hour or so, assuming that the CI pipeline passes. For that, see the PR at ​https://github.com/JOSM/Mapillary/pull/213 .