Opened 3 years ago
Last modified 23 months ago
#22940 new enhancement
add autofix for node[ŧype=multipolygon] and most way[type=multipolygon] — at Initial Version
| Reported by: | marc_marc | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | template_report type multipolygon | Cc: |
Description
What steps will reproduce the problem?
- create a node with natural=tree type=multipolygon
- create a way with landuse=residential type=multipolygon
- run the validator
What is the expected result?
have a autofix for both
What happens instead?
the validator detect the issue without a autofix
https://josm.openstreetmap.de/browser/trunk/resources/data/validator/geometry.mapcss#L90
https://josm.openstreetmap.de/browser/trunk/resources/data/validator/geometry.mapcss#L139
proposed enhancement
node[type=multipolygon] {
throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
fixRemove: "type";
}
way!:closed[type=multipolygon] {
throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}");
fixRemove: "type";
}
way:area-style[type=multipolygon] {
throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}");
fixRemove: "type";
}
I didn't combine both way with way[type=multipolygon] because some wrong usage of way[type=multipolygon] mean area=yes (for ex when converting a relation type=multipolygon highway=pedestrian into a closed way)
Please provide any additional information below. Attach a screenshot if possible.
URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2023-05-09 19:06:23 +0200 (Tue, 09 May 2023) Build-Date:2023-05-10 01:30:56 Revision:18722 Relative:URL: ^/trunk Identification: JOSM/1.5 (18722 fr) Linux CentOS Linux release 7.9.2009 (Core) Memory Usage: 473 MB / 1717 MB (220 MB allocated, but free) Java version: 1.8.0_362-b08, Red Hat, Inc., OpenJDK 64-Bit Server VM Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel Screen: :0.0 1600×900 (scaling 1.00×1.00) Maximum Screen Size: 1600×900 Best cursor sizes: 16×16→16×16, 32×32→32×32 Environment variable LANG: fr.utf8 System property file.encoding: UTF-8 System property sun.jnu.encoding: UTF-8 Locale info: fr_CH Numbers with default locale: 1234567890 -> 1234567890 Desktop environment: GNOME-Classic:GNOME Java package: java-1.8.0-openjdk:x86_64-1.8.0.362.b08 WebStart package: icedtea-web:x86_64-1.7.1 VM arguments: [-Dicedtea-web.bin.name=javaws.itweb, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb] Dataset consistency test: No problems found Plugins: + ImproveOsm (238) + MapRoulette + apache-commons (36034) + apache-http (35924) + areaselector + austriaaddresshelper (master-4e80dc2e4261d321150187f4951684ad97342d5e) + cadastre-fr (36079) + conflation (0.6.11) + continuosDownload (105) + ejml (35924) + geotools (36068) + jackson (36034) + jaxb (35952) + jna (36005) + jts (36004) + log4j (36045) + mapwithai (794) + notesolver (0.5.0) + opendata (36079) + pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT) + reverter (36066) + scripting + todo (123) + utilsplugin2 (36079) + wikipedia (605) Tagging presets: + https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1 + https://raw.github<user.name>content.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml + https://josm.openstreetmap.de/josmfile?page=Presets/BENELUX&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/MountainbikeTrails&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/geoimage.at&zip=1 + https://github.com/Jungle-Bus/josm-presets/raw/gh-pages/jungle-stops/Preset_Jungle-Bus.zip + https://josm.openstreetmap.de/josmfile?page=Presets/MobilePhoneBaseStations&zip=1 + https://raw.github<user.name>content.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml + https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1 + https://raw.github<user.name>content.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml + https://osmtools.de/josm/steps.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Trees&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/WifiHotspots&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Wikidata&zip=1 + https://raw.github<user.name>content.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1 Validator rules: + https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip + https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/MissingOpeningHours&zip=1 + https://raw.github<user.name>content.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss + https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss + https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/Pictures&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1 + https://raw.github<user.name>content.com/osmlu/josm-validator-luxembourg/master/Luxembourg-Specific-Rules.validator.mapcss + https://raw.github<user.name>content.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss + https://josm.openstreetmap.de/josmfile?page=Rules/OsmoseValidations&zip=1 + <josm.pref>/validator/osmose.zip + https://josm.openstreetmap.de/josmfile?page=Rules/FacebookWebsite&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/InvalidWebsiteProtocol&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/PublicTransportGtfs&zip=1 + https://josm.openstreetmap.de/josmfile?page=Rules/ValidatingBuildingsInHOTTMProjects&zip=1 + <josm.pref>/validator/Rules_Marcmarc.addon.validator.mapcss + <josm.pref>/validator/Rules_Marcmarc.depreciated-parking.validator.mapcss + <josm.pref>/validator/Rules_Marcmarc.depreciated.validator.mapcss + <josm.pref>/validator/Rules_Marcmarc.error.validator.mapcss + <josm.pref>/validator/Rules_Marcmarc.useless.validator.mapcss + <josm.pref>/validator/Rules_Marcmarc.depreciated-wooded.validator.mapcss Last errors/warnings:
Note:
See TracTickets
for help on using tickets.
