source: josm/trunk/resources/data/validator/geometry.mapcss

Last change on this file was 18536, checked in by Klumbumbus, 6 months ago

see #21836 - Improve error messages (use only key instead of whole tag)

  • Property svn:eol-style set to native
File size: 15.8 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway][footway!=crossing], /* footway=crossing has own warning in highway.mapcss */
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43  throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44  assertMatch: "node oneway=-1";
45  assertNoMatch: "way oneway=-1";
46  assertMatch: "node bridge=yes";
47  assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52  throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; #10679 #16528 #16792 #12502 #17402*/
56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
59node[area=yes],
60node[area:highway],
61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
75node[natural=glacier],
76node[leisure=park][natural!=tree], /* For nodes with both tags another warning is created in combinations.mapcss */
77node[leisure=nature_reserve],
78node[waterway=riverbank],
79node[man_made=bridge],
80node[man_made=breakwater],
81node[aeroway=apron],
82node[power=plant],
83node[power=switchgear],
84node[building:part],
85node[source:outline] {
86  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
87}
88
89/* {0} on a node, should be a relation; Error level; #10252, #10769, #14288 */
90node[type=multipolygon],
91node[interval],
92node[route],
93node[restriction] {
94  throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}"); 
95}
96
97/* {0} on a way, should be a node (0.tag) */
98way[emergency=fire_hydrant],
99way[emergency=defibrillator],
100way[railway=subway_entrance],
101way[man_made=survey_point],
102way[power=transformer],
103way[power=pole],
104way[power=catenary_mast],
105way[power=connection],
106way[power=terminal],
107way[power=tower]!:closed,
108way[amenity=vending_machine],
109way[natural=peak],
110way[natural=saddle],
111way[natural=volcano],
112way[natural=tree],
113way[highway=give_way],
114way[highway=milestone],
115way[highway=mini_roundabout],
116way[highway=stop],
117way[highway=street_lamp],
118way[highway=traffic_signals],
119way[highway=turning_loop],
120way[highway=turning_circle],
121way[highway=motorway_junction] {
122  throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}"); 
123}
124
125/* {0} on a way, should be a node (0.key) */
126way[voltage:primary],
127way[voltage:secondary],
128way[voltage:tertiary],
129way[transformer],
130way[line_attachment],
131way[line_management],
132way[entrance],
133way[door] {
134  throwWarning: tr("{0} on a way. Should be used on a node.", "{0.key}"); 
135}
136
137/* {0} on a way, should be a relation; #15642, #10252, #14288 */
138way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
139way[type=multipolygon],
140way[interval][route!=ferry],
141way[route=bus] {
142  throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}"); 
143}
144
145/* {0} on a closed way, should be a unclosed way; #19981 */
146way:closed[power=line] {
147  throwWarning: tr("{0} on a closed way. Should be used on an unclosed way.", "{1.tag}"); 
148}
149
150/* #20902 */
151relation[area?] {
152  throwWarning: tr("{0} on a relation", "{0.key}");
153  fixRemove: "{0.key}";
154}
155
156/* #14395, #17025, #19506 */
157way[highway][area!=yes][!tunnel][!covered] > node {
158  set node_in_highway;
159}
160way[highway][area!=yes][!tunnel][!covered]:closed > node {
161  set node_in_closed_highway;
162}
163way[highway][area!=yes][!tunnel][!covered] >[index=1] node,
164way[highway][area!=yes][!tunnel][!covered] >[index=-1] node {
165  set first_last_highway_node;
166}
167way[building][building!=no] > node[!entrance].node_in_closed_highway {
168  set node_connects_highway_and_building; /* avoids duplicate warnings with following rule */
169  throwWarning: tr("node connects highway and building");
170}
171way[building][building!=no] > node[!entrance].node_in_highway!.first_last_highway_node!.node_connects_highway_and_building {
172  throwWarning: tr("node connects highway and building");
173}
174
175/* #15035, must not warn for node 3815077900*/
176node[man_made!=monitoring_station][at(0.0,0.0)] {
177  throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
178  fixDeleteObject: this;
179}
180
181/* #10125 */
182node[source:geometry] {
183  throwWarning: tr("{0} on a node", "{0.key}");
184  fixChangeKey: "source:geometry => source:position";
185}
186
187/* Building inside building (spatial test) */
188*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] 
189area[building][building!~/no|entrance/] {
190  throwWarning: tr("Building inside building");
191}
192
193/* Building overlapping building or building:part (spatial test) */
194area[building][building!~/no|entrance/]  area[building:part][building:part!~/no|entrance/],
195area[building][building!~/no|entrance/]  area[building][building!~/no|entrance/] {
196  throwWarning: tr("Overlapping buildings");
197}
198
199/* Overlapping areas (spatial test) */
200area[natural =~ /^(water|wetland|coastline)$/], area[waterway=riverbank], area[landuse=reservoir] {
201  set water_area;
202}
203
204/* area:closed.water_area ⧉ area:closed.water_area -- does not work for now -- see ticket#10215 */
205area:closed[natural =~ /^(water|wetland|coastline)$/]  area:closed.water_area,
206area:closed[waterway=riverbank]                        area:closed.water_area,
207area:closed[landuse=reservoir]                         area:closed.water_area {
208  throwWarning: tr("Overlapping Water Areas");
209}
210
211/* Water area inside water area (spatial test) */
212area:closed[natural =~ /^(water|wetland|coastline)$/]   area:closed.water_area,
213area:closed[waterway=riverbank]                         area:closed.water_area,
214area:closed[landuse=reservoir]                          area:closed.water_area,
215area:closed[natural =~ /^(water|wetland|coastline)$/]   area:closed.water_area,
216area:closed[waterway=riverbank]                         area:closed.water_area,
217area:closed[landuse=reservoir]                          area:closed.water_area {
218  throwWarning: tr("Water area inside water area");
219}
220
221area:completely_downloaded:closed:areaStyle  area:completely_downloaded:closed:areaStyle {
222  throwOther: tr("Overlapping Areas");
223}
224
225/* #9311 */
226node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/]  area[amenity=parking] {
227  throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
228  group: tr("{0} inside {1}", "amenity", "amenity");
229}
230
231/* #9556, #20570 */
232area:closed:areaStyle[tag("natural") = parent_tag("natural")]  area:closed:areaStyle[natural][natural !~ /^(water|wetland|coastline)$/] {
233  throwWarning: tr("Overlapping Identical Natural Areas");
234}
235
236area:closed[tag("landuse") = parent_tag("landuse")]  area:closed[landuse] {
237  throwWarning: tr("Overlapping Identical Landuses");
238}
239
240/* #9522 */
241node[tag("amenity") = parent_tag("amenity")]  area[amenity][amenity != parking] {
242  throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
243  group: tr("{0} inside {1}", "amenity", "amenity");
244}
245node[tag("leisure") = parent_tag("leisure")]  area[leisure] {
246  throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
247  group: tr("{0} inside {1}", "leisure", "leisure");
248}
249node[tag("tourism") = parent_tag("tourism")]  area[tourism] {
250  throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
251  group: tr("{0} inside {1}", "tourism", "tourism");
252}
253node[tag("shop") = parent_tag("shop")]  area[shop] {
254  throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
255  group: tr("{0} inside {1}", "shop", "shop");
256}
257node[tag("power") = parent_tag("power")]  area[power] {
258  throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
259  group: tr("{0} inside {1}", "power", "power");
260}
261
262/* isolated nodes which should be part of a way; #10825, #15478, #21688 */
263node:unconnected:in-downloaded-area[entrance],
264node:unconnected:in-downloaded-area[traffic_calming],
265node:unconnected:in-downloaded-area[highway=passing_place],
266node:unconnected:in-downloaded-area[highway=mini_roundabout],
267node:unconnected:in-downloaded-area[highway=motorway_junction],
268node:unconnected:in-downloaded-area[highway=turning_loop],
269node:unconnected:in-downloaded-area[highway=turning_circle],
270node:unconnected:in-downloaded-area[highway=stop],
271node:unconnected:in-downloaded-area[highway=give_way],
272node:unconnected:in-downloaded-area[highway=traffic_signals],
273node:unconnected:in-downloaded-area[highway=crossing],
274node:unconnected:in-downloaded-area[crossing],
275node:unconnected:in-downloaded-area[railway=milestone],
276node:unconnected:in-downloaded-area[railway=crossing],
277node:unconnected:in-downloaded-area[railway=level_crossing],
278node:unconnected:in-downloaded-area[railway=buffer_stop],
279node:unconnected:in-downloaded-area[public_transport=stop_position],
280node:unconnected:in-downloaded-area[aeroway=holding_position],
281node:unconnected:in-downloaded-area[noexit],
282node:unconnected:in-downloaded-area[waterway=dam],
283node:unconnected:in-downloaded-area[waterway=weir],
284node:unconnected:in-downloaded-area[waterway=waterfall],
285node:unconnected:in-downloaded-area[amenity=ferry_terminal],
286node:unconnected:in-downloaded-area[leisure=slipway],
287node:unconnected:in-downloaded-area[mountain_pass=yes],
288node:unconnected:in-downloaded-area[barrier=gate],
289node:unconnected:in-downloaded-area[barrier=lift_gate],
290node:unconnected:in-downloaded-area[barrier=swing_gate],
291node:unconnected:in-downloaded-area[barrier=toll_booth],
292node:unconnected:in-downloaded-area[barrier=turnstile],
293node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
294node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
295node:unconnected:in-downloaded-area[barrier=rope],
296node:unconnected:in-downloaded-area[barrier=sally_port],
297node:unconnected:in-downloaded-area[barrier=spikes],
298node:unconnected:in-downloaded-area[barrier=stile],
299node:unconnected:in-downloaded-area[barrier=sump_buster],
300node:unconnected:in-downloaded-area[barrier=kerb],
301node:unconnected:in-downloaded-area[barrier=border_control],
302node:unconnected:in-downloaded-area[barrier=bump_gate],
303node:unconnected:in-downloaded-area[barrier=bus_trap],
304node:unconnected:in-downloaded-area[barrier=cattle_grid],
305node:unconnected:in-downloaded-area[barrier=chain],
306node:unconnected:in-downloaded-area[barrier=cycle_barrier],
307node:unconnected:in-downloaded-area[barrier=hampshire_gate],
308node:unconnected:in-downloaded-area[barrier=height_restrictor],
309node:unconnected:in-downloaded-area[barrier=debris] {
310  throwWarning: tr("{0}", "{2.tag}");
311  group: tr("isolated node which must be connected to a way");
312}
313
314/* #11127 */
315way[railway][bridge] > node,
316way[highway][bridge] > node {
317  set node_in_bridge;
318}
319way[waterway] > node.node_in_bridge {
320  throwWarning: tr("node connects waterway and bridge");
321}
322
323/* #11128, #14812, #15032 */
324way[highway] > node[tourism=information][information=guidepost] {
325  set guidepost;
326  throwOther: tr("{0} node connected to a highway", "{1.tag}");
327}
328way >[index=1] node,
329way >[index=-1] node {
330  set first_last_node;
331}
332way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi|toilets|ticket_validator)$/],
333way[highway] > node[building][!entrance],
334way[highway] > node[leisure][!entrance][leisure!=slipway][leisure!=fitness_station],
335way[highway] > node[office][!entrance],
336way[highway][highway!=corridor] > node[shop][!entrance],
337way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
338way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
339  throwWarning: tr("{0} node connected to a highway", "{0.key}");
340}
341
342/* #18817 */
343way[man_made=pipeline][location=underground] > node[marker],
344way[power=cable      ][location=underground] > node[marker] {
345  throwWarning: tr("{0} node connected to an underground object", "{0.key}");
346}
347
348way[junction=roundabout]:righthandtraffic:clockwise,
349way[junction=roundabout]!:righthandtraffic:anticlockwise {
350  throwWarning: tr("suspicious roundabout direction");
351}
352
353/* #12496 */
354area:closed[place=islet][eval(areasize()) > 1500000] {
355  throwWarning: tr("{0} on a large area", "{1.tag}");
356  suggestAlternative: "place=island";
357  fixAdd: "place=island";
358}
359
360area:closed[place=island][eval(areasize()) < 500000] {
361  throwWarning: tr("{0} on a small area", "{1.tag}");
362  suggestAlternative: "place=islet";
363  fixAdd: "place=islet";
364}
365
366/* #12561 - building larger than Lada car factory (906280 m^2 in OSM) way id 47121317 at N53.56, E49.25, https://en.wikipedia.org/wiki/List_of_largest_buildings#Largest_footprint*/
367area:closed[building][building!=no][eval(areasize()) > 920000] {
368  throwError: tr("Too large building");
369}
370
371/* #12646, #12992, #16334 */
372way[waterway=~/^(stream|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance][waterway!=stream_end]!:connection:in-downloaded-area { 
373  throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
374}
375
376/* #10717, #14535 */
377way:closed[natural=coastline]  area[natural=water],
378way:closed[natural=coastline]  area[waterway=riverbank] {
379  throwError: tr("Coastline inside {1}", "{0.tag}");
380}
381
382/* #10471 */
383way[waterway] > node[ford?] { set ford_on_waterway; }
384way[highway] > node[ford?] { set ford_on_highway; }
385node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
386    throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
387}
388
389/* #13877 */
390area:closed[waterway = canal][area!=no],
391area:closed[waterway = drain][area!=no],
392area:closed[waterway = ditch][area!=no],
393area:closed[waterway = stream][area!=no],
394area:closed[waterway = river][area!=no] {
395  throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
396}
397
398/* #15097 */
399way[highway][area!=yes] > node,
400way[man_made=pier] > node {
401  set node_in_highway_pier;
402}
403way[route=ferry][tunnel=yes] > node,
404way[route=ferry][bridge=yes] > node {
405  set node_in_ferry_bridge_tunnel;
406}
407way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
408way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
409  throwWarning: tr("Ferry route is not connected to the road network or branches.");
410}
411way[amenity=ferry_terminal] > node,
412way[man_made=pier] > node {
413  set node_in_terminal_pier;
414}
415way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
416way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
417  throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
418}
Note: See TracBrowser for help on using the repository browser.