[patch] Anonymize VM arguments in status reports

[gaben]

A JOSM instance in debugging can have special VM arguments which can contain sensitive information, like the user home dir. If someone creates bug report int that state, the VM arguments become visible.

See for example one of my previous report #22845, where I manually changed the -javaagent param to hide the username.

src/org/openstreetmap/josm/actions/ShowStatusReportAction.java

@@ -159 +159 @@
                     text.format("WebStart package: %s%n", webStartDetails);
                 }
             }
-            // Add Gnome Atk wrapper details if found
+            // Add Gnome ATK wrapper details if found
             String atkWrapperDetails = platform.getAtkWrapperPackageDetails();
             if (atkWrapperDetails != null) {
                 text.format("Java ATK Wrapper package: %s%n", atkWrapperDetails);
             }
-            // Add dependencies details if found
+            // Add dependency details if found
             for (String p : new String[] {
                     "apache-commons-compress", "libcommons-compress-java",
                     "apache-commons-jcs-core",
@@ -207 +207 @@
                 }
             }
             if (!vmArguments.isEmpty()) {
-                text.format("VM arguments: %s%n", vmArguments.toString().replace("\\\\", "\\"));
+                text.format("VM arguments: %s%n", paramCleanup(vmArguments).toString().replace("\\\\", "\\"));
             }
         } catch (SecurityException e) {
             Logging.trace(e);
@@ -280 +280 @@
     }
 
     /**
-     * Shortens and removes private informations from a parameter used for status report.
+     * Shortens and removes private information from a parameter used for status report.
      * @param param parameter to cleanup
      * @return shortened/anonymized parameter
      */

[gaben]

Maybe it fits in the March release :)

[taylor.smock]

Ticket retargeted after milestone closed

[taylor.smock]

In 18707/josm:

Fix #22846: Anonymize VM arguments in status reports (patch by gaben)

This is mostly useful if the user sets the JOSM home directory.