[Patch] JOSM shows geotagged images in the wrong location

[GerdP]

What steps will reproduce the problem?

1. load saved session with several layers of geotagged images, possibly containing some missing images
2. activate "center view" in the image view popup
3. click on "Next" button

What is the expected result?

JOSM shows the next image and centers the map view to the location of that image

What happens instead?

JOSM shows the next image but may not center the view correctly. If I got that right this happens when the *.joz file refers to an image which no longer exists on the disk. The view seems to be centered on that non-existing image but the popup shows another image.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-14 22:49:24 +0100 (Tue, 14 Mar 2023)
Revision:18693
Build-Date:2023-03-15 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18693 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 1238 MB / 1972 MB (223 MB allocated, but free)
Java version: 17.0.4+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18531, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35924)
+ RoadSigns (36038)
+ apache-commons (36034)
+ buildings_tools (36011)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ o5m (35893)
+ opendata (36025)
+ pbf (36034)
+ poly (35976)
+ reltoolbox (35976)
+ reverter (36043)
+ undelete (36011)
+ utilsplugin2 (36011)

Validator rules:
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ c:\josm\core\resources\data\validator\unnecessary.mapcss
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- 00000.709 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.712 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00002.311 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00347.638 E: java.io.FileNotFoundException: F:\osm\bilder\2023-01-06\DSC_2551.JPG (Das System kann die angegebene Datei nicht finden)
- 00353.942 E: java.io.FileNotFoundException: F:\osm\bilder\2023-01-06\DSC_2551.JPG (Das System kann die angegebene Datei nicht finden)
- 00367.577 E: java.io.FileNotFoundException: F:\osm\bilder\2023-01-06\DSC_2551.JPG (Das System kann die angegebene Datei nicht finden)
- 00374.726 E: java.io.FileNotFoundException: F:\osm\bilder\2023-01-06\DSC_2551.JPG (Das System kann die angegebene Datei nicht finden)
- 00382.654 E: java.io.FileNotFoundException: F:\osm\bilder\2023-01-06\DSC_2551.JPG (Das System kann die angegebene Datei nicht finden)
- 00395.134 E: java.io.FileNotFoundException: F:\osm\bilder\2023-01-06\DSC_2551.JPG (Das System kann die angegebene Datei nicht finden)

[GerdP]

Same problem occurs with tested version r18678.

[GerdP]

Further info: I've extracted the file session.jos, removed the entry about the missing image and updated the *.joz with the modified file. Is there a "normal" way to get rid of an non-existing image in a saved session? This seems to fix the problem for the missing image.
I don't remember if I removed the image within JOSM or not, but I am pretty sure that I did it intentionally.

So, it seems the eror handling with missing images in JOSM is somehow wrong. Not sure if it should show a warning about the missing image or if it should silently jump to the next one (and center the view correctly).

[GerdP]

src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java

@@ -979 +979 @@
     private void updateButtonsNonNullEntry(IImageEntry<?> entry, boolean imageChanged) {
         if (imageChanged) {
             cancelLoadingImage();
+            // don't show unwanted image
+            imgDisplay.setImage(null);
             // Set only if the image is new to preserve zoom and position if the same image is redisplayed
             // (e.g. to update the OSD).
             imgLoadingFuture = imgDisplay.setImage(entry);

[GerdP]

In 18945/josm:

fix #22819: JOSM shows geotagged images in the wrong location

• if a new image should be shown, make sure that we don't show the previous one. Instead, show only the loading message.