[Patch] Cannot disable tabs in image viewer

[GerdP]

What steps will reproduce the problem?

1. Change the setting geoimage.viewer.show.tabs to false
2. restart JOSM
3. open georeferenced image from one layer
4. open georeferenced image from another layer

What is the expected result?

No tabs in the image popup, one image using all the available space in the dialog

What happens instead?

(possibly lots of) tabs with the layer name are displayed and image is reduced to a smaller area

Please provide any additional information below. Attach a screenshot if possible.

I don't know if the preference is meant to change this behaviour but the name surely implies this.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-01 15:17:42 +0100 (Wed, 01 Mar 2023)
Revision:18678
Build-Date:2023-03-02 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18678 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 1634 MB / 1972 MB (590 MB allocated, but free)
Java version: 17.0.4+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18531, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35924)
+ RoadSigns (36038)
+ apache-commons (36034)
+ buildings_tools (36011)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ o5m (35893)
+ opendata (36025)
+ pbf (36034)
+ poly (35976)
+ reltoolbox (35976)
+ reverter (36043)
+ undelete (36011)
+ utilsplugin2 (36011)

Validator rules:
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ c:\josm\core\resources\data\validator\unnecessary.mapcss
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- 00000.655 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.658 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00002.174 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 60670.355 E: java.io.FileNotFoundException: F:\osm\bilder\2022-12-20\DSC_3010.JPG (Das System kann die angegebene Datei nicht finden)
- 60955.186 E: java.io.FileNotFoundException: F:\osm\bilder\2023-01-06\DSC_2551.JPG (Das System kann die angegebene Datei nicht finden)

[marcus-steffen]

I find many properties in the source code with geoimage.*. However, I cannot find the property geoimage.viewer.show.tabs. That would explain why it has no effect. How did you find out that it exists?

[gaben]

Replying to marcus-steffen:

I cannot find the property geoimage.viewer.show.tabs.

source:josm/trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java?rev=18686#L896​

[skyper]

#22860 seems to be related.

[GerdP]

let preference geoimage.viewer.show.tabs=false actually disable tabs in the geo image viewer

[GerdP]

In 18944/josm:

fix #22806 Cannot disable tabs in image viewer and #22860 Geotagged Images dialog confuses tabs
If preference geoimage.viewer.show.tabs=false is set, make sure that only the recent image is selected