IllegalArgumentException when conflating after using MWAI merge function

[watmildon]

What steps will reproduce the problem?

1. Use conflation tool to match addresses and buildings
2. Review matches and merge some nodes using the MWAI Shift+A (usually mismatched and long distance)
3. Hit Conflate after reviewing

What is the expected result?

Conflate the remaining results

What happens instead?

IAE

Please provide any additional information below. Attach a screenshot if possible.

Revision:18646
Build-Date:2023-01-30 15:15:00

Identification: JOSM/1.5 (18646 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19045)
Memory Usage: 3514 MB / 4088 MB (2137 MB allocated, but free)
Java version: 17.0.6+10-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1440×2560 (scaling 1.00×1.00) \Display1 3840×2160 (scaling 1.50×1.50)
Maximum Screen Size: 3840×2560
Best cursor sizes: 16×16→48×48, 32×32→48×48
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18646, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35978)
+ FixAddresses (36011)
+ MapRoulette (1676030679)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36011)
+ conflation (0.6.9)
+ continuosDownload (105)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36028)
+ gridify (1606242219)
+ imagery_offset_db (35978)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ mapwithai (1.10.4)
+ opendata (36025)
+ reverter (36043)
+ tageditor (36011)
+ terracer (35978)
+ todo (30306)
+ turnrestrictions (36011)
+ utilsplugin2 (36011)
+ wikipedia (605)

Map paint styles:
+ %UserProfile%\Address Tags Validator - Highlight unaddressed
+ https://josm.openstreetmap.de/josmfile?page=Styles/TigerReviewedNo&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 217660.470 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 840727513] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.476 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 840727295] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.482 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 840629631] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.488 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 840727167] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.494 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 841013541] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.500 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 840727287] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.506 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 840727012] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.512 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 840727517] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.515 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 840615162] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 217660.538 E: Handled by bug report queue: org.openstreetmap.josm.tools.bugreport.ReportedException: java.lang.IllegalArgumentException: {Node id=-2530449 version=0 MVDT lat=33.66900999975,lon=-112.36680000027} is already deleted. Cause: java.lang.IllegalArgumentException: {Node id=-2530449 version=0 MVDT lat=33.66900999975,lon=-112.36680000027} is already deleted



=== REPORTED CRASH DATA ===
sequence_information:
 - sequence_name: Sequence: 
 - sequence_command: Replace geometry for node House number 14426 at West Desert Glen Drive
 - sequence_index: 2
 - sequence_commands: [org.openstreetmap.josm.command.AddPrimitivesCommand;org.openstreetmap.josm.plugins.conflation.command.SetSelectedCommand;org.openstreetmap.josm.plugins.utilsplugin2.replacegeometry.ReplaceGeometryCommand;org.openstreetmap.josm.plugins.conflation.command.RemoveMatchCommand]
 - sequence_commands_descriptions: [Added 1 object;Selected 1 object;Replace geometry for node House number 14426 at West Desert Glen Drive;Delete 1 conflation match]

BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (23) of main
ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=java.lang.IllegalArgumentException: {Node id=-2530449 version=0 MVDT lat=33.66900999975,lon=-112.36680000027} is already deleted, methodWarningFrom=null]
	at org.openstreetmap.josm.command.SequenceCommand.createReportedException(SequenceCommand.java:146)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:114)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:112)
	at org.openstreetmap.josm.plugins.conflation.command.ConflateMatchCommand.executeCommand(ConflateMatchCommand.java:81)
	at org.openstreetmap.josm.plugins.conflation.command.StopOnErrorSequenceCommand.executeCommand(StopOnErrorSequenceCommand.java:58)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:300)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:354)
	at org.openstreetmap.josm.plugins.conflation.ConflationToggleDialog$ConflateAction.conflateMatchActionPerformed(ConflationToggleDialog.java:824)
	at org.openstreetmap.josm.plugins.conflation.ConflationToggleDialog$ConflateAction.actualActionPerformed(ConflationToggleDialog.java:803)
	at org.openstreetmap.josm.plugins.conflation.ConflationToggleDialog$BatchAction.actionPerformed(ConflationToggleDialog.java:654)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.desktop/java.awt.Component.processMouseEvent(Unknown Source)
	at java.desktop/javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.desktop/java.awt.Component.processEvent(Unknown Source)
	at java.desktop/java.awt.Container.processEvent(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.IllegalArgumentException: {Node id=-2530449 version=0 MVDT lat=33.66900999975,lon=-112.36680000027} is already deleted
	at org.openstreetmap.josm.command.DeleteCommand.lambda$executeCommand$0(DeleteCommand.java:211)
	at org.openstreetmap.josm.data.osm.DataSet.update(DataSet.java:1008)
	at org.openstreetmap.josm.command.DeleteCommand.executeCommand(DeleteCommand.java:207)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:112)
	... 44 more

[watmildon]

I have been playing around with this on and off to try and get a nice simple repro but haven't cracked it. I still suspect it's some combination of adding using the MWAI functionality while also having run a conflation but it doesn't seem to be trivial to strip down and repro. If this comes up again I'll makes some more notes here.