IAE: node is already deleted

[CatSu]

JOSM prompted me to send a bug report after pressing the update plugin button after the mapwithAI plugin seemed to crash while adding buildings. Other than that, I have no idea what happened.

Please provide any additional information below. Attach a screenshot if possible.

Revision:18622
Build-Date:2023-01-04 12:54:08

Identification: JOSM/1.5 (18622 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 1850 MB / 3068 MB (809 MB allocated, but free)
Java version: 17.0.5+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18622, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (36034)
+ apache-http (35924)
+ editgpx (35931)
+ jna (36005)
+ mapwithai (v1.10.2)
+ utilsplugin2 (36011)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 06533.713 E: java.nio.file.AccessDeniedException: <josm.cache>\mirror_https___josm.openstreetmap.de_josmfile_page_Styles_MapWithAI_zip_1.tmp -> <josm.cache>\mirror_https___josm.openstreetmap.de_josmfile_page_Styles_MapWithAI_zip_1
- 06537.720 W: Could not move autosaved file MapWithAI_20230114_192546075.osm to deleted_layers folder
- 06537.721 W: Unable to delete backup file <josm.pref>\autosave\MapWithAI_20230114_192546075.osm
- 06548.424 E: Failed to locate image 'https://prd-wret.s3.us-west-2.amazonaws.com/assets/palladium/production/s3fs-public/styles/content_list_thumbnail/public/thumbnails/image/USGS_logo_green_SQUARE.png'
- 08734.947 E: java.nio.file.AccessDeniedException: <josm.cache>\mirror_https___josm.openstreetmap.de_josmfile_page_Styles_MapWithAI_zip_1.tmp -> <josm.cache>\mirror_https___josm.openstreetmap.de_josmfile_page_Styles_MapWithAI_zip_1
- 11785.889 W: Unable to delete old backup file <josm.pref>\autosave\MapWithAI_20230114_200314230.osm
- 12086.027 W: Unable to delete old backup file <josm.pref>\autosave\MapWithAI_20230114_205317724.osm
- 12385.878 W: Unable to delete old backup file <josm.pref>\autosave\MapWithAI_20230114_205817873.osm
- 12685.880 W: Unable to delete old backup file <josm.pref>\autosave\MapWithAI_20230114_210317725.osm
- 12793.514 E: Handled by bug report queue: org.openstreetmap.josm.tools.bugreport.ReportedException: ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=java.lang.IllegalArgumentException: {Node id=7141552492 version=1 MVDT lat=38.4982243,lon=-90.3615397} is already deleted, methodWarningFrom=null], methodWarningFrom=null]. Cause: org.openstreetmap.josm.tools.bugreport.ReportedException: ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=java.lang.IllegalArgumentException: {Node id=7141552492 version=1 MVDT lat=38.4982243,lon=-90.3615397} is already deleted, methodWarningFrom=null]. Cause: org.openstreetmap.josm.tools.bugreport.ReportedException: java.lang.IllegalArgumentException: {Node id=7141552492 version=1 MVDT lat=38.4982243,lon=-90.3615397} is already deleted. Cause: java.lang.IllegalArgumentException: {Node id=7141552492 version=1 MVDT lat=38.4982243,lon=-90.3615397} is already deleted



=== REPORTED CRASH DATA ===
sequence_information:
 - sequence_name: Sequence: Add object from MapWithAI
 - sequence_command: Create connections from MapWithAI data
 - sequence_index: 1
 - sequence_commands: [org.openstreetmap.josm.plugins.mapwithai.commands.MovePrimitiveDataSetCommand;org.openstreetmap.josm.plugins.mapwithai.commands.CreateConnectionsCommand]
 - sequence_commands_descriptions: [Move OsmPrimitives between layers;Create connections from MapWithAI data]

BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (23) of main
ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=java.lang.IllegalArgumentException: {Node id=7141552492 version=1 MVDT lat=38.4982243,lon=-90.3615397} is already deleted, methodWarningFrom=null], methodWarningFrom=null], methodWarningFrom=null]
	at org.openstreetmap.josm.command.SequenceCommand.createReportedException(SequenceCommand.java:146)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:114)
	at org.openstreetmap.josm.plugins.mapwithai.commands.CreateConnectionsCommand.executeCommand(CreateConnectionsCommand.java:68)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:112)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWait(GuiHelper.java:225)
	at org.openstreetmap.josm.plugins.mapwithai.commands.MapWithAIAddCommand.run(MapWithAIAddCommand.java:110)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWait(GuiHelper.java:225)
	at org.openstreetmap.josm.plugins.mapwithai.commands.MapWithAIAddCommand.executeCommand(MapWithAIAddCommand.java:84)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:300)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:354)
	at org.openstreetmap.josm.plugins.mapwithai.backend.MapWithAIMoveAction.lambda$actionPerformed$1(MapWithAIMoveAction.java:90)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWait(GuiHelper.java:225)
	at org.openstreetmap.josm.plugins.mapwithai.backend.MapWithAIMoveAction.actionPerformed(MapWithAIMoveAction.java:90)
	at java.desktop/javax.swing.SwingUtilities.notifyAction(Unknown Source)
	at java.desktop/javax.swing.JComponent.processKeyBinding(Unknown Source)
	at java.desktop/javax.swing.KeyboardManager.fireBinding(Unknown Source)
	at java.desktop/javax.swing.KeyboardManager.fireKeyboardAction(Unknown Source)
	at java.desktop/javax.swing.JComponent.processKeyBindingsForAllComponents(Unknown Source)
	at java.desktop/javax.swing.JComponent.processKeyBindings(Unknown Source)
	at java.desktop/javax.swing.JComponent.processKeyEvent(Unknown Source)
	at java.desktop/java.awt.Component.processEvent(Unknown Source)
	at java.desktop/java.awt.Container.processEvent(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)
Caused by: ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=java.lang.IllegalArgumentException: {Node id=7141552492 version=1 MVDT lat=38.4982243,lon=-90.3615397} is already deleted, methodWarningFrom=null], methodWarningFrom=null]
	at org.openstreetmap.josm.command.SequenceCommand.createReportedException(SequenceCommand.java:146)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:114)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:112)
	... 49 more
Caused by: ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=java.lang.IllegalArgumentException: {Node id=7141552492 version=1 MVDT lat=38.4982243,lon=-90.3615397} is already deleted, methodWarningFrom=null]
	at org.openstreetmap.josm.command.SequenceCommand.createReportedException(SequenceCommand.java:146)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:114)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:112)
	... 50 more
Caused by: java.lang.IllegalArgumentException: {Node id=7141552492 version=1 MVDT lat=38.4982243,lon=-90.3615397} is already deleted
	at org.openstreetmap.josm.command.DeleteCommand.lambda$executeCommand$0(DeleteCommand.java:211)
	at org.openstreetmap.josm.data.osm.DataSet.update(DataSet.java:1008)
	at org.openstreetmap.josm.command.DeleteCommand.executeCommand(DeleteCommand.java:207)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:112)
	... 51 more

[taylor.smock]

I've been able to reproduce the problem or something like it.

It looks like I didn't check to see if the node was already deleted before trying to merge it. Or that is my best guess, anyway.

@CatSu: A workaround until I get a fix out (I'll try to do that today) is to move address nodes off of the building before you delete it.

[taylor.smock]

Fixed in ​v1.10.3. It should be available in JOSM in the next 20-30 minutes.