Modify

Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#22606 closed defect (fixed)

Anomalies with tabs in the geoimage viewer window

Reported by: Adrian Owned by: team
Priority: normal Milestone: 22.12
Component: Core image mapping Version: latest
Keywords: template_report image viewer Cc:

Description

What steps will reproduce the problem?

  1. Launch JOSM or delete all layers if JOSM is already running.
  2. Load the session file from here as described at the end of ticket:21605#comment:41.

What is the expected result?

After the image is loaded, the image icon is highlighted, a tab is visible, and the title bar of the image viewer window contains the name of the layer.
OR: No image is loaded at this stage.

What happens instead?

The first image in the lowest layer (IMG_20190909_162714.JPG) is loaded immediately, but no image icon is highlighted. There is a vestigial tab. The title bar of the image viewer window says Geotagged Images instead of the name of the layer. There is a second, empty, image viewer window behind the first image viewer window.

  1. Click the leftmost image icon. Note that IMG_20190914_172915.JPG is now loaded.

What is the expected result?

A second tab is created, next to the tab which should already be there.

What happens instead?

Two tabs appear. If you bring another application to the front, the empty window goes in front of the populated window.

  1. Click the non-selected tab in the image viewer window to go back to the previous image.

What is the expected result?

The image changes. The tab (for layer 20190909) works normally.

What happens instead?

The image does not change. The tab for layer 20190909 does not start to work normally until you have clicked on an icon in that layer, e.g. the third from the left.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-12-21 19:35:50 +0100 (Wed, 21 Dec 2022)
Revision:18618
Build-Date:2022-12-23 02:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18618 en_GB) Mac OS X 11.7.2
OS Build number: macOS 11.7.2 (20G1020)
Memory Usage: 434 MB / 4096 MB (183 MB allocated, but free)
Java version: 18.0.2.1+1, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1007312129 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_GB.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890

Plugins:
+ ImportImagePlugin (36013)
+ InfoMode (35978)
+ PicLayer (1.0.2)
+ apache-commons (36003)
+ cadastre-fr (36021)
+ editgpx (35931)
+ ejml (35924)
+ geotools (36028)
+ http2 (35921)
+ imagery_offset_db (35978)
+ jackson (36006)
+ jaxb (35952)
+ jts (36004)
+ log4j (36007)
+ measurement (35978)
+ opendata (36025)
+ photo_geotagging (35933)
+ poly (35976)
+ reverter (36011)
+ turnrestrictions (36011)
+ undelete (36011)
+ utilsplugin2 (36011)
+ waydownloader (36011)

Last errors/warnings:
- 00003.755 W: Update plug-ins - You updated your JOSM software. To prevent problems the plug-ins should be updated as well.  Update plug-ins now?
- 00028.007 E: java.io.FileNotFoundException: /Volumes/Untitled/20190909/IMG_20190909_162714.JPG (No such file or directory)
- 00051.650 E: java.io.FileNotFoundException: /Volumes/Untitled/20190914/IMG_20190914_172915.JPG (No such file or directory)
- 00153.007 E: java.io.FileNotFoundException: /Volumes/Untitled/20190909/IMG_20190909_162714.JPG (No such file or directory)
- 00156.265 E: java.io.FileNotFoundException: /Volumes/Untitled/20190914/IMG_20190914_172915.JPG (No such file or directory)

Attachments (0)

Change History (6)

comment:1 by taylor.smock, 23 months ago

I'm not seeing this behavior, or at least, what I think you are saying the behavior is.

I still have a (modified) version of the session file you uploaded (and linked to in the ticket description), and everything worked as I expected. The only modification was for the image paths, BTW (since I don't have the original images).

EDIT: I was using a different session file from #21605.

Last edited 23 months ago by taylor.smock (previous) (diff)

comment:2 by taylor.smock, 23 months ago

Ticket #22607 has been marked as a duplicate of this ticket.

comment:3 by taylor.smock, 23 months ago

Resolution: fixed
Status: newclosed

In 18621/josm:

Fix #22606: Images with no exif position or no set position were treated as if they had no position

This is incorrect behavior, since the paint code only cares about the return
value of IImageEntry#getPos, and invalid geoimages should be those that can
not be shown in the mapview.

This also fixes an issue where, when the layer has no images with positions, the
first image would be displayed, but not selected in the data.

comment:4 by Adrian, 23 months ago

Thank you for the quick fix. It is a good improvement. It has also resolved many of the other issues which I had discovered, but for which I had not yet found time to submit tickets.

comment:5 by taylor.smock, 23 months ago

It did seem to be the root cause of most or all the problems you had reported, so I figured I'd ask you to try with the patch before filing more tickets.

Anyway, thanks for the bug report.

comment:6 by Klumbumbus, 23 months ago

Milestone: 22.12

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.