Modify

Opened 2 years ago

Last modified 2 years ago

#22582 new defect

Conflation plugin not robust to item manipulation/deletions

Reported by: watmildon Owned by: Tyndare
Priority: normal Milestone:
Component: Plugin conflation Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Add address nodes and building areas and conflate
  2. Start working through the list looking for outliers etc, sometimes modifying elements
  3. Select all remaining and hit conflate

What is the expected result?

Successful conflation or maybe an warning about unfound elements?

What happens instead?

Exception

Please provide any additional information below. Attach a screenshot if possible.

Revision:18583
Build-Date:2022-11-01 14:35:40

Identification: JOSM/1.5 (18583 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19045)
Memory Usage: 1980 MB / 4088 MB (675 MB allocated, but free)
Java version: 17.0.5+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1440×2560 (scaling 1.00×1.00) \Display1 3840×2160 (scaling 1.50×1.50)
Maximum Screen Size: 3840×2560
Best cursor sizes: 16×16→48×48, 32×32→48×48
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18583, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35978)
+ FixAddresses (36011)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36011)
+ conflation (0.6.9)
+ continuosDownload (105)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36028)
+ gridify (1606242219)
+ imagery_offset_db (35978)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ mapwithai (484cba1)
+ opendata (36025)
+ tageditor (36011)
+ terracer (35978)
+ turnrestrictions (36011)
+ utilsplugin2 (36011)
+ wikipedia (605)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 29835.416 E: java.nio.file.AccessDeniedException: <josm.cache>\mirror_https___josm.openstreetmap.de_josmfile_page_Styles_MapWithAI_zip_1.tmp -> <josm.cache>\mirror_https___josm.openstreetmap.de_josmfile_page_Styles_MapWithAI_zip_1
- 29975.738 E: java.nio.file.AccessDeniedException: <josm.cache>\mirror_https___josm.openstreetmap.de_josmfile_page_Styles_MapWithAI_zip_1.tmp -> <josm.cache>\mirror_https___josm.openstreetmap.de_josmfile_page_Styles_MapWithAI_zip_1
- 30177.020 W: Unable to delete old backup file <josm.pref>\autosave\MapWithAI_20221216_192900642.osm
- 30477.265 W: Unable to delete old backup file <josm.pref>\autosave\MapWithAI_20221216_193400354.osm
- 30777.245 W: Unable to delete old backup file <josm.pref>\autosave\MapWithAI_20221216_193900601.osm
- 30849.724 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 867912738] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 30861.403 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 867912737] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 30870.857 E: java.lang.IllegalStateException: JOSM expected to find primitive [way 867912730] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- 31033.276 E: Handled by bug report queue: org.openstreetmap.josm.tools.bugreport.ReportedException: java.lang.IllegalArgumentException: {Node id=-231510 version=0 MVDT lat=39.77593590215121,lon=-86.16392494118439} is already deleted. Cause: java.lang.IllegalArgumentException: {Node id=-231510 version=0 MVDT lat=39.77593590215121,lon=-86.16392494118439} is already deleted
- 31077.254 W: Unable to delete old backup file <josm.pref>\autosave\MapWithAI_20221216_194400581.osm



=== REPORTED CRASH DATA ===
sequence_information:
 - sequence_name: Sequence: 
 - sequence_command: Replace geometry for node House number 312 at West North Street
 - sequence_index: 2
 - sequence_commands: [org.openstreetmap.josm.command.AddPrimitivesCommand;org.openstreetmap.josm.plugins.conflation.command.SetSelectedCommand;org.openstreetmap.josm.plugins.utilsplugin2.replacegeometry.ReplaceGeometryCommand;org.openstreetmap.josm.plugins.conflation.command.RemoveMatchCommand]
 - sequence_commands_descriptions: [Added 1 object;Selected 1 object;Replace geometry for node House number 312 at West North Street;Delete 1 conflation match]

BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (23) of main
ReportedException [thread=Thread[AWT-EventQueue-0,6,main], exception=java.lang.IllegalArgumentException: {Node id=-231510 version=0 MVDT lat=39.77593590215121,lon=-86.16392494118439} is already deleted, methodWarningFrom=null]
	at org.openstreetmap.josm.command.SequenceCommand.createReportedException(SequenceCommand.java:146)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:114)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:112)
	at org.openstreetmap.josm.plugins.conflation.command.ConflateMatchCommand.executeCommand(ConflateMatchCommand.java:81)
	at org.openstreetmap.josm.plugins.conflation.command.StopOnErrorSequenceCommand.executeCommand(StopOnErrorSequenceCommand.java:58)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:300)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:354)
	at org.openstreetmap.josm.plugins.conflation.ConflationToggleDialog$ConflateAction.conflateMatchActionPerformed(ConflationToggleDialog.java:824)
	at org.openstreetmap.josm.plugins.conflation.ConflationToggleDialog$ConflateAction.actualActionPerformed(ConflationToggleDialog.java:803)
	at org.openstreetmap.josm.plugins.conflation.ConflationToggleDialog$BatchAction.actionPerformed(ConflationToggleDialog.java:654)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.desktop/java.awt.Component.processMouseEvent(Unknown Source)
	at java.desktop/javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.desktop/java.awt.Component.processEvent(Unknown Source)
	at java.desktop/java.awt.Container.processEvent(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.IllegalArgumentException: {Node id=-231510 version=0 MVDT lat=39.77593590215121,lon=-86.16392494118439} is already deleted
	at org.openstreetmap.josm.command.DeleteCommand.lambda$executeCommand$0(DeleteCommand.java:211)
	at org.openstreetmap.josm.data.osm.DataSet.update(DataSet.java:1008)
	at org.openstreetmap.josm.command.DeleteCommand.executeCommand(DeleteCommand.java:207)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:112)
	... 44 more

Attachments (0)

Change History (1)

comment:1 by taylor.smock, 2 years ago

Component: CorePlugin conflation
Owner: changed from team to Tyndare

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Tyndare.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Tyndare to the specified user.
Next status will be 'needinfo'. The owner will be changed from Tyndare to watmildon.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from Tyndare to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.