Complain about merging square and marketplace into one object

[mkoniecz]

What steps will reproduce the problem?

1. Create closed way
2. Tag it highway=pedestrian amenity=marketplace
3. Run validator

What is the expected result?

Validator complains about violating ​https://wiki.openstreetmap.org/wiki/One_feature,_one_OSM_element

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

While highway=pedestrian amenity=marketplace may seem innocent it gets progressively nastier as more properties are added - for example name: should it apply to marketplace, both or road?

Also, is highway=pedestrian amenity=marketplace are or closed linear way?

Reporting all highway=* amenity=* objects may be tempting but it will degenerate into long list of exclusions and special cases.

About 500 cases worldwide right now ( ​https://overpass-turbo.eu/s/1p2z ) so not extremely popular - but it is a serious one resulting in annoying handling for data consumers (for start, will break routers that bothered to implement time-dependendent routing and respect opening_hours)

Triggered by ​https://github.com/streetcomplete/StreetComplete/issues/4681 but it would be problem also if StreetComplete would not crash on encountering this.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-11-23 19:12:12 +0100 (Wed, 23 Nov 2022)
Revision:18604
Build-Date:2022-11-25 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18604 en) Linux Ubuntu 20.04.5 LTS
Memory Usage: 588 MB / 3974 MB (325 MB allocated, but free)
Java version: 11.0.17+8-post-Ubuntu-1ubuntu220.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00) :0.1 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.17+8-1ubuntu2~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (36011)
+ measurement (35978)
+ reverter (36011)
+ todo (30306)

Map paint styles:
+ ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
- ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss
+ ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss

Last errors/warnings:
- 00008.446 W: Failed to load Mappaint styles from '${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss'. Exception was: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss
- 00008.447 E: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss
- 00008.452 E: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard
- 00008.452 W: Initializing map style ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss completed in 6 ms (1 errors, 0 warnings)
- 00013.032 W: Failed to add ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss to tag checker
- 00013.036 W: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss

[mkoniecz]

I would be happy to provide patch if it would be likely to be accepted.

[Klumbumbus]

(no patch required)

[Klumbumbus]

In 18626/josm:

fix #22576 - Warn about amenity=marketplace together with highway