Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22570 closed defect (invalid)

do not warn about building=entrance on areas

Reported by: dieterdreist Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: building, entrance Cc:

Description

I mapped an entrance building to a cemetery and got a warning about the tag "building=entrance" but the suggested "entrance" key is not really related to this situation. Generally, the hint about building=entrance (a tag that is only 1/100th of what it was some years ago), should only be given on nodes and not on closed ways and other areas.

Attachments (0)

Change History (8)

comment:1 by taylor.smock, 3 years ago

Resolution: invalid
Status: newclosed

Please talk this out on the OSM Wiki ( osmwiki:Tag:building=entrance ) and tagging mailing lists.

The wiki currently indicates that the tag is deprecated (and page history indicates it has been that way for close to a decade). I am strongly disinclined to override something like that in JOSM.

If you get community buy-in for this specific use case, feel free to re-open this ticket.

comment:2 by anonymous, 3 years ago

You are right that there is a wiki page about a deprecated tag, building=entrance, but it only refers to nodes, and is about the tag used "To mark the location of a building entrance". Clearly this is a different case than tagging an actual building (whole building) with the tag.

comment:3 by taylor.smock, 3 years ago

Yes, the wiki page only refers to nodes.

Just because the tag was for nodes on building ways does not mean it should be repurposed for a building type. If only because it means that the wiki page needs to show multiple statuses, one for nodes on building ways, and the other for building objects, which will confuse mappers.

I suspect the "right" way to map the entrance building would be to tag the building as something (building=yes if nothing else, but probably building=gatehouse), and then mark the entrance/exit with entrance=<whatever>.

comment:4 by dieterdreist, 3 years ago

I don’t agree that we shouldnt have a building=entrance tag just because this tag was unsuitable for building entrances and nonetheless used for this 10 years ago. Building=* is encouraged as a valid tag in the wiki, building=yes would be poorer and building=gatehouse is not exactly what seems right.

I will not start a community discussion in other places because it does not seem worth the hazzle, I just ignored the warning and wanted to give you a hint that the check is outdated and overeager. If you think it is better to warn about this tag on closed ways than it is to ignore the tag on everything but nodes, just do nothing because Josm is already behaving like this.

Last edited 3 years ago by dieterdreist (previous) (diff)

in reply to:  4 comment:5 by taylor.smock, 3 years ago

Replying to dieterdreist:

I will not start a community discussion in other places because it does not seem worth the hazzle, [...]

You aren't helping your case here. Please get other people involved. If you don't do that, don't be surprised if a future mapper looks at the tagging and changes it to something else, like building=gatehouse. Furthermore, without supporting documentation, I would not be surprised if a year or two from now someone comes by and asks us to flag building=entrance on all objects, since it is deprecated.

I just ignored the warning and wanted to give you a hint that the check is outdated and overeager. [...]

Maybe building=entrance is fine today, when it is used on a building where its purpose is to be the entrance for a wider area.

Regardless, I highly recommend that you communicate on the tagging list. I am open to making changes after community discussion, but I don't want to single-handedly change the meaning of deprecated by myself.

comment:6 by dieterdreist, 3 years ago

Thank you for replying, I have decided to follow your request and have written to the tagging ML to ask for comments on the tag.
https://lists.openstreetmap.org/pipermail/tagging/2022-December/066643.html

comment:7 by taylor.smock, 3 years ago

Thank you. Hopefully your discussion is productive. :)

comment:8 by mkoniecz, 3 years ago

I encountered buildings constructed as entrance and tried to use building=entrance for them but retagged them as building=entrance was causing JOSM warning.

Once I used building=entrance_building and considered opening ticket like this one but ended somehow not doing it.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.