Modify

Opened 15 years ago

Closed 15 years ago

#2257 closed enhancement (fixed)

[PATCH] update information=* usage

Reported by: vsandre Owned by: ce
Priority: minor Milestone:
Component: Internal preset Version: latest
Keywords: Cc: ulfl

Description

  • add information office, map and board as seperate selection
  • changed amenity=signpost to informaton=guidepost

Attachments (5)

information_patch.zip (42.7 KB ) - added by vsandre 15 years ago.
presets.xml, elementstyles.xml and icons
elementstyles.patch (3.1 KB ) - added by vsandre 15 years ago.
patch on elementstyles.xml
icons_used_in_patch.zip (26.0 KB ) - added by vsandre 15 years ago.
Icons used in the patch
presets.patch (4.2 KB ) - added by vsandre 15 years ago.
patch of presets.xml
elemstyles.patch (3.3 KB ) - added by vsandre 15 years ago.
patch of elemstyles.xml

Download all attachments as: .zip

Change History (11)

by vsandre, 15 years ago

Attachment: information_patch.zip added

presets.xml, elementstyles.xml and icons

by vsandre, 15 years ago

Attachment: elementstyles.patch added

patch on elementstyles.xml

comment:1 by stoecker, 15 years ago

comment:2 by ce, 15 years ago

Currently I need to reject this patch (though it looks valuable), as it uses tabs instead of blanks for indentation, uses nonexistent icons (if in doubt, use empty.png instead) and crashes JOSM when using, for example:
<key key="tourism" value="informaton" />
<key key="information" value="guidepost" />

While
<key key="tourism" value="informaton" />
<key key="information" values="guidepost" />
would not cause a crash, it would not set the second key.

Hint:
You can try out your edits by merging them directly into the jar:
jar uf josm-latest.jar images/ presets/ styles/

comment:3 by stoecker, 15 years ago

The icons are probably in the zip he uploaded first

by vsandre, 15 years ago

Attachment: icons_used_in_patch.zip added

Icons used in the patch

by vsandre, 15 years ago

Attachment: presets.patch added

patch of presets.xml

by vsandre, 15 years ago

Attachment: elemstyles.patch added

patch of elemstyles.xml

comment:4 by vsandre, 15 years ago

With your tip i testet the patch myself an saw the same failures. The problem was that i deleted the normal tourism=information in the presets.

But now it works very well vor me.

comment:5 by stoecker, 15 years ago

Cc: ulfl added

comment:6 by ce, 15 years ago

Resolution: fixed
Status: newclosed

Committed. Thanks for your valuable contribution.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ce.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.