Opened 16 years ago
Closed 16 years ago
#2257 closed enhancement (fixed)
[PATCH] update information=* usage
Reported by: | vsandre | Owned by: | ce |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Internal preset | Version: | latest |
Keywords: | Cc: | ulfl |
Description
- add information office, map and board as seperate selection
- changed amenity=signpost to informaton=guidepost
Attachments (5)
Change History (11)
by , 16 years ago
Attachment: | information_patch.zip added |
---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Currently I need to reject this patch (though it looks valuable), as it uses tabs instead of blanks for indentation, uses nonexistent icons (if in doubt, use empty.png instead) and crashes JOSM when using, for example:
<key key="tourism" value="informaton" />
<key key="information" value="guidepost" />
While
<key key="tourism" value="informaton" />
<key key="information" values="guidepost" />
would not cause a crash, it would not set the second key.
Hint:
You can try out your edits by merging them directly into the jar:
jar uf josm-latest.jar images/ presets/ styles/
comment:4 by , 16 years ago
With your tip i testet the patch myself an saw the same failures. The problem was that i deleted the normal tourism=information in the presets.
But now it works very well vor me.
comment:5 by , 16 years ago
Cc: | added |
---|
comment:6 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Committed. Thanks for your valuable contribution.
presets.xml, elementstyles.xml and icons