Opened 4 months ago

Last modified 8 days ago

#22556 reopened enhancement

[patch] Complain about building=roof + addr:*

Reported by: Famlam Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: roof fuel address Cc:

Description (last modified by skyper)

Currently there are about 50k cases where addr:* tags are placed on a building with building=roof (not to be confused with building:part=roof)

Addresses are typically not located on (in?) the roof of the building, but rather point at the object that's under the roof. Additionally, as the majority of these tags seem to be for amenity=fuel (60k in combination with building=roof), the wiki page of amenity=fuel also indicates one should make a separate area for the roof.

Hence, I would propose to add either:

way[building=roof][amenity=fuel] {
  throwOther: tr("{0} together with {1}, usually {1} is located underneath the {2}", "{0.tag}", "{1.tag}", "{0.value}");
  group: tr("suspicious tag combination");


way[building=roof][/^addr:/] {
  throwOther: tr("{0} together with {1}, usually addresses refer to objects underneath the {2}", "{0.tag}", "{1.tag}", "{0.value}");
  group: tr("suspicious tag combination");

Attachments (0)

Change History (8)

comment:1 Changed 4 months ago by taylor.smock

I get where you are coming from, with a caveat that in some cases the building=roof section will be larger than the service building and cover or almost cover the service building (I have a couple of examples in my area, although one is in the process of being torn down and rebuilt).

I'm disinclined to apply the patch for amenity=fuel objects because of that.

You might also want to see how people actually tag fuel stations -- I've seen people put all the tags on the "roof" of the fueling area, so I suspect osmwiki:Tag:amenity=fuel does not conform to current tagging practices. This also means that putting the addr tags on the roof makes sense. In some cases.

comment:2 Changed 3 months ago by Famlam

Resolution: wontfix
Status: newclosed

I'll close it as WontFix for now then.

comment:3 Changed 3 months ago by skyper

How about an informational warning (Others)?

comment:4 Changed 3 months ago by Famlam

Resolution: wontfix
Status: closedreopened

How about an informational warning (Others)?

I'm in favor, of course :)

comment:5 Changed 3 months ago by Famlam

Description: modified (diff)

comment:6 Changed 3 months ago by skyper

Description: modified (diff)
Keywords: address added

use one more placeholder

comment:7 Changed 6 weeks ago by Famlam

@taylor.smock, what's your opinion on a 'throwOther' warning as Skyper proposes? If you oppose, I'll close the issue again, otherwise it'd probably stay open forever :)

comment:8 Changed 8 days ago by 1ec5

A gas station POI is not necessarily located underneath the roof; that would be a osmwiki:Tag:man_made=fuel_pump. The wiki mentions a "fueling area", which has been interpreted differently by different mappers. However, this is no different than how some mappers dual-tag the nearby building as a convenience store while others prefer to keep it as a separate node inside the building. By this logic, a convenience store is also inside the building, not identical to it, but a warning about dual-tagging any building with an amenity would be quite noisy.

Modify Ticket

Change Properties
Set your email in Preferences
as reopened The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Famlam
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.