[Patch] possibly improve performance in class `ChangesetDataSet`

[GerdP]

When reading changesets, JOSM repeatedly may call method getPrimitiveId() for the same object in ChangesetDataSet.put() which is called when a changeset is read. Unless the run time optimizer can kick in this method creates a new SimplePrimitiveId instance each time it is called. The patch creates a single instance and uses map.computeIfAbsent() as recommended by sonarlint.

[taylor.smock]

Thanks for profiling this. :)

It looks like SimplePrimitiveId could be a value/record class. Unfortunately, we aren't on Java 14+ yet. And I'd have to check for binary compatibility problems with plugins.

Anyway, it looks good to me.

[GerdP]

In 18606/josm:

fix #22529: possibly improve performance in class ChangesetDataSet

• avoid repeated calls of getPrimitiveId() which creates instances of SimplePrimitiveId
• use map.computeIfAbsent() as recommended by sonarlint

[GerdP]

Oops, sorry, did not see that the milestone is one off. Revert?

[taylor.smock]

No. I had been intending to do a release this week, then I started getting bug reports for something I changed three weeks ago.

[GerdP]

Maybe like the one in #22538?

[taylor.smock]

Yep, I fixed that in r18605, and now people are coming out of the woodwork with feedback. Which is the whole reason why I did the modification three weeks ago -- so people would have time to give feedback before the 22.11 release.

See #21605 for the discussion on the patch.

[skyper]

@Taylor:
Thanks for your work. Please, do not be too disappointed as time is relative. At least we got around a hotfix so far. One question would be how to get more people to use latest.

[taylor.smock]

We could try changing the bug report window to say something along the lines of Please consider running josm-latest(link) so we can avoid bugs in josm-tested.

Or maybe, in the wiki:StartupPage, we can have a running list of upcoming changes for feedback.

So

Upcoming changes (in JOSM latest, next release {planned [date]|postponed due to bug reports to [date]})

• Add tabs to the ImageViewer (see #21605, feedback would be appreciated)
• OAuth 2 support (expert mode only until July 2023)

[taylor.smock]

Milestone renamed