java.lang.NullPointerException in MapillaryExportDownloadThread

[anonymous]

What steps will reproduce the problem?

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-10-06 21:10:57 +0200 (Thu, 06 Oct 2022)
Build-Date:2022-10-07 01:30:59
Revision:18570
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18570 en) Mac OS X 10.16
OS Build number: macOS 12.6 (21G115)
Memory Usage: 2236 MB / 3641 MB (1447 MB allocated, but free)
Java version: 1.8.0_301-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1 1440×900 (scaling 1.00×1.00) Display 2 3440×1440 (scaling 1.00×1.00)
Maximum Screen Size: 3440×1440
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0)
+ apache-commons (36003)
+ apache-http (35924)
+ jna (36005)
+ osm-obj-info (66)

Tagging presets:
+ ${HOME}/Desktop/FB_presets.max.xml

Map paint styles:
+ ${HOME}/Desktop/SnefflesActual.mapcss
+ ${HOME}/Documents/signs/street_signs.mapcss

Validator rules:
+ ${HOME}/Desktop/FB_rules5.14.validator.mapcss

Last errors/warnings:
- 00271.486 E: Handled by bug report queue: java.lang.NullPointerException
- 00271.487 W: Too many errors. Dropping ReportedException [thread=Thread[pool-3-thread-3,5,main], exception=java.lang.NullPointerException, methodWarningFrom=BugReportExceptionHandler#handleException]
- 00272.463 E: Handled by bug report queue: java.lang.NullPointerException
- 00272.464 W: Too many errors. Dropping ReportedException [thread=Thread[pool-3-thread-22,5,main], exception=java.lang.NullPointerException, methodWarningFrom=BugReportExceptionHandler#handleException]
- 00272.470 E: Handled by bug report queue: java.lang.NullPointerException
- 00272.470 W: Too many errors. Dropping ReportedException [thread=Thread[pool-3-thread-18,5,main], exception=java.lang.NullPointerException, methodWarningFrom=BugReportExceptionHandler#handleException]
- 00272.474 E: Handled by bug report queue: java.lang.NullPointerException
- 00272.476 W: Too many errors. Dropping ReportedException [thread=Thread[pool-3-thread-29,5,main], exception=java.lang.NullPointerException, methodWarningFrom=BugReportExceptionHandler#handleException]
- 00272.479 E: Handled by bug report queue: java.lang.NullPointerException
- 00272.483 W: Too many errors. Dropping ReportedException [thread=Thread[pool-3-thread-40,5,main], exception=java.lang.NullPointerException, methodWarningFrom=BugReportExceptionHandler#handleException]



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: pool-3-thread-2 (499)
java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.mapillary.io.export.MapillaryExportDownloadThread.loadingFinished(MapillaryExportDownloadThread.java:72)
	at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.finishLoading(JCSCachedTileLoaderJob.java:265)
	at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.handleJobCancellation(JCSCachedTileLoaderJob.java:590)
	at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.cancelOutstandingTasks(JCSCachedTileLoaderJob.java:572)
	at org.openstreetmap.josm.plugins.mapillary.cache.MapillaryCache.submit(MapillaryCache.java:250)
	at org.openstreetmap.josm.plugins.mapillary.cache.CacheUtils.submit(CacheUtils.java:70)
	at org.openstreetmap.josm.plugins.mapillary.io.export.MapillaryExportDownloadThread.run(MapillaryExportDownloadThread.java:60)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

[taylor.smock]

It looks like this is due to killing old download threads as quickly as possible, to avoid filling up the queue and making a user wait.

[taylor.smock]

Fixed in ​7c5c79f93c5b9a8022b1dd11519fc68754a75761.