[PATCH] NPE when clicking on map in "PicLayer move point" mode and while background image tiles are loading

[joihoin]

What steps will reproduce the problem?

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-09-29 20:51:54 +0200 (Thu, 29 Sep 2022)
Revision:18565
Build-Date:2022-09-30 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18565 en) Linux Ubuntu 22.04.1 LTS
Memory Usage: 1637 MB / 3930 MB (646 MB allocated, but free)
Java version: 11.0.16+8-post-Ubuntu-0ubuntu122.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Screen: :0.0 5120×1440 (scaling 1.00×1.00)
Maximum Screen Size: 5120×1440
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: Regolith:GNOME-Flashback:GNOME
Java package: openjdk-11-jre:amd64-11.0.16+8-0ubuntu1~22.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.38.0-5build1
libcommons-compress-java: libcommons-compress-java:all-1.21-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20201225-1build1
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ PicLayer (1.0.2)

Last errors/warnings:
- 05489.148 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 05489.542 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 07027.681 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 07028.024 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 07044.941 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 07045.342 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 07073.490 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 07073.845 E: Failed to locate image 'https://www.naturvardsverket.se/assets/static/media/apple-touch-icon.8ec47f26.png'
- 07091.804 E: Handled by bug report queue: java.lang.NullPointerException
- 07097.949 E: Handled by bug report queue: java.lang.NullPointerException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (20) of main
java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.piclayer.actions.transform.affine.MovePointAction.mouseClicked(MovePointAction.java:56)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:278)
	at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6638)
	at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
	at java.desktop/java.awt.Component.processEvent(Component.java:6400)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5011)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4556)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[taylor.smock]

I've got a PR open at ​https://github.com/JOSM/PicLayer/pull/5 .

The fix is fairly simple, but I'm not terribly familiar with the code (I took a quick look through and I was tempted to remove the problematic calls initially, but then I looked at the docs, and I think the actions are supposed to trigger on the initial mouse click instead of on mouse release).

I don't know how active rebsc is, but I'll give her a week or so to look at the PR before I merge it.

[rebsc]

Merged at ​7e248c8