Add farmland=* to farmland preset

[SekeRob]

Missing code line for item Farmland in bold

<item name="Farmland" icon="presets/landuse/farmland.svg" type="closedway,multipolygon" preset_name_label="true">

<link wiki="Tag:landuse=farmland" />
<space />
<key key="landuse" value="farmland" />

<combo key="farmland" text="Type of farmland" values="field;mixed,arable;pasture;terraced;vegetables;wetland" values_context="farmland" />
<optional>

<combo key="crop" text="Crop" values="barley,cereal,corn,grass,hop,rape,rice,soy,sugarcane,tea,wheat" values_context="crop" />
<text key="name" text="Name" />
<check key="irrigation" text="Center pivot irrigation" value_on="pivot" disable_off="true" />

</optional>

</item> <!-- Farmland -->

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Revision:18543
Build-Date:2022-08-30 13:34:09

Identification: JOSM/1.5 (18543 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 348 MB / 4084 MB (125 MB allocated, but free)
Java version: 17.0.4+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18543, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]

Plugins:
+ buildings_tools (36011)
+ pt_assistant (1ff2e15)
+ reltoolbox (35976)
+ reverter (36011)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- 00000.565 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.568 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00001.089 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00010.649 E: Failed to locate image 'bus.png'

[Klumbumbus]

from ​https://wiki.openstreetmap.org/wiki/Key:farmland
"This key has not been defined. The more common values are duplicates of more established tags or do not add information."

Wontfix for now.

[taylor.smock]

In that case, we should probably ignore it (30k instances).

It is, oddly enough not in our source code, nor is it showing up in the testCheckPopularTags test. It looks like it is due to missing a wiki entry, which is (probably?) a parse error for TagInfo.

[Klumbumbus]

Replying to taylor.smock:

It is, oddly enough not in our source code, nor is it showing up in the testCheckPopularTags test. It looks like it is due to missing a wiki entry, which is (probably?) a parse error for TagInfo.

It doesn't show up in the test because there is no tag (not key) > 10k with a wiki page.
The only tag >10k is farmland=field which has no wiki page.

[mkoniecz]

Also, big chunk of it is a badly done import: see ​https://taginfo.openstreetmap.org/keys/farmland#chronology