complain about image=https://westnordost.de/*

[mkoniecz]

What steps will reproduce the problem?

1. Tag image=https://westnordost.de/p/17484.jpg like ​https://www.openstreetmap.org/node/8280027078
2. Run validator

What is the expected result?

"images links such as ​https://westnordost.de/p/17484.jpg will become invalid few days after note is closed and should be never treated as permanent - you can upload own photos to Wikimedia Commons and use wikimedia_commons tag to link them"

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

See ​https://taginfo.openstreetmap.org/keys/image#values - over 2600 various images were linked (some people made webarchive copies and linked that which is still problematic as image is "all right reserved" but at least it will be kept online)

See also ​https://github.com/streetcomplete/StreetComplete/issues/4409 and ​https://github.com/openstreetmap/id-tagging-schema/issues/591 (iD equivalent for tha report)

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-09-18 18:03:33 +0200 (Sun, 18 Sep 2022)
Revision:18559
Build-Date:2022-09-19 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18559 en) Linux Ubuntu 20.04.4 LTS
Memory Usage: 420 MB / 3974 MB (128 MB allocated, but free)
Java version: 11.0.16+8-post-Ubuntu-0ubuntu120.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00) :0.1 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.16+8-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (36011)
+ measurement (35978)
+ reverter (36011)
+ todo (30306)

Map paint styles:
+ ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
- ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss
+ ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss

Last errors/warnings:
- 00012.760 W: Failed to load Mappaint styles from '${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss'. Exception was: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss
- 00012.762 E: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss
- 00012.769 E: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard
- 00012.771 W: Initializing map style ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss completed in 12 ms (1 errors, 0 warnings)
- 00016.293 W: Failed to add ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss to tag checker
- 00016.293 W: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss

[Klumbumbus]

I would suggest the following which could be expanded to other websites as well as to the keys url or website in the future.

*[image][image=~/westnordost.de\/p\//] {
  throwWarning: tr("{0} with a temporary URL which will be outdated very soon", "{0.key}");
  fixRemove: "{0.key}";
  assertMatch: "node image=https://westnordost.de/p/17484.jpg";
  assertNoMatch: "node image=https://commons.wikimedia.org/wiki/File:2015-05-13_Basteibr%C3%BCcke-.jpg";
}

Checking westnordost urls in the tags url and website is not needed as there are only a handful of cases which can be quickly cleaned up manually.

[mkoniecz]

I would also add

assertNoMatch: "node image=https://web.archive.org/web/20220623215400/https://westnordost.de/p/97331.jpg

it is a bit problematic, but definitely not for "temporary URL which will be outdated very soon" reasons.

Also, maybe change "temporary URL which will be outdated very soon" to "temporary URL which may be outdated very soon"?

This images in general will stay present as long as note is open

[Klumbumbus]

OK, thanks for the feedback.

[Klumbumbus]

In 18564/josm:

fix #22397 - Warn about temporary image URLs starting with https://westnordost.de/p/

[mkoniecz]

Thanks for quick reaction! I hope that it will prevent wasted effort and people will be more likely to save their images.