Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22375 closed enhancement (fixed)

boundaries.osm - add Scotland and Flanders, Wallonia, Brussels

Reported by: westnordost Owned by: westnordost
Priority: minor Milestone: 22.12
Component: Core Version:
Keywords: boundaries Cc:

Description (last modified by westnordost)

Added subdivision Scotland (GB-SCT) and all subdivisions of Belgium - Flanders (BE-VLG), Wallonia (BE-WAL), Brussels (BE-BRU).

Guideline followed in terms of precision: Settlements and at least the more important roads must be on the right side of the border.

Rationale:

  1. Scotland has some autonomy that leads to some rules and regulations being different from the rest of the United Kingdom that may be relevant to OpenStreetMap data. For example, the speed limits are different. (See https://wiki.openstreetmap.org/wiki/Default_speed_limits)
  1. The languages spoken and official in Belgium are different depending on the subdivision. Dutch in Flanders (and Brussels), French in Wallonia (and Brussels). This is relevant for OpenStreetMap data, as in Brussels, (traffic) signs usually are multilingual while in Flanders and Wallonia, they are not.
  1. The different regions in Belgium have some different rules and regulations. for example, the speed limits are different. (See https://wiki.openstreetmap.org/wiki/Default_speed_limits)

Motivation:

If you wonder why I contribute here at all, read on. (TLDR: boundaries.osm is being used by a couple more OSM-related projects to infer country-specific metadata):

The countryboundaries Java library uses this file as default input data. That library is at least used by StreetComplete and Vespucci to infer some country-specific metadata that helps users to input the correct data (maintained at github repo countrymetadata.
This is especially handy for things like displaying which languages for street sign names must/should be entered, e.g. in Brussels Dutch and French, but many other too (see officalLanguages.yml).

Additionally, this file is at least used by GraphHopper to also infer some country-specific metadata, such as speed limits.

Maybe specifically countryboundaries or countrymetadata would be interesting to you JOSM developers too, let me know.

Attachments (2)

boundaries-scotland-belgium.osm (1.9 MB ) - added by westnordost 3 years ago.
boundaries-scotland-belgium-5digits.osm (1.9 MB ) - added by westnordost 3 years ago.
as previous file but coords cut to 5 decimals

Change History (18)

by westnordost, 3 years ago

comment:1 by westnordost, 3 years ago

(obsolete)

Last edited 3 years ago by westnordost (previous) (diff)

in reply to:  1 comment:2 by skyper, 3 years ago

Replying to osm@…:

(I don't seem to be able to edit the description text)

You need to register and than login for that.

comment:3 by westnordost, 3 years ago

Description: modified (diff)

comment:4 by westnordost, 3 years ago

thanks, I did

comment:5 by westnordost, 3 years ago

So, any problem with the submitted file?

in reply to:  5 comment:6 by Klumbumbus, 3 years ago

Keywords: boundaries added
Milestone: 22.11

Replying to westnordost:

So, any problem with the submitted file?

No it looks fine. Thank you!

comment:7 by Klumbumbus, 3 years ago

Resolution: fixed
Status: newclosed

In 18594/josm:

fix #22375 - Add subdivision Scotland (GB-SCT) and all subdivisions of Belgium - Flanders (BE-VLG), Wallonia (BE-WAL), Brussels (BE-BRU) to internal boundaries file (patch by westnordost)

comment:8 by Klumbumbus, 3 years ago

Resolution: fixed
Status: closedreopened

comment:9 by Klumbumbus, 3 years ago

Owner: changed from team to westnordost
Status: reopenedneedinfo

I overlooked, the coordinates should be rounded to 5 decimal places and the action='modify' should be removed. Could you create a patch for this?

by westnordost, 3 years ago

as previous file but coords cut to 5 decimals

comment:10 by westnordost, 3 years ago

Sure, I attached the file

comment:11 by Klumbumbus, 3 years ago

Resolution: fixed
Status: needinfoclosed

In 18595/josm:

fix #22375 - Clean up boundaries file (patch by westnordost)

in reply to:  10 comment:12 by Klumbumbus, 3 years ago

Replying to westnordost:

Sure, I attached the file

Thanks.

comment:13 by taylor.smock, 3 years ago

@westnordost: In the future, when you have a patch, can you add [PATCH] to the description? See https://josm.openstreetmap.de/report/8 for how it would show up.

I tend to prioritize crashing bugs -> patches -> other random tickets. At a glance, this looks like a feature request so I probably skipped it when going through my RSS feed of recently modified/created tickets.

comment:14 by westnordost, 3 years ago

Sure, I will try to remember next time :-)

Did you consider to change trac with github, gitlab (self-hosted or on gitlab.com), gitea (or non-self-hosted on e.g. codeberg.org), Fossil or similar? With the concept of pull requests / merge requests, contributing by non-project members gets really somewhat easier. On the other hand, if contributing becomes more frictionless, it might also lead to more unsolicited contributions and more work for maintainers. But anyway, just wanted to mention this, you probably did consider this before... but maybe you didn't consider (self-hosted) alternatives to github.

comment:15 by taylor.smock, 3 years ago

Take a look at #16857. Which is kind of dead in the water. We do have a GitHub SVN mirror (https://github.com/JOSM/josm), but the PRs aren't always checked, and most of them have a corresponding ticket on Trac.

With all that said, we have a lot of stuff that is dependent upon Trac and scripts which integrate with Trac.

comment:16 by taylor.smock, 3 years ago

Milestone: 22.1122.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain westnordost.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.