Modify ↓

Opened 20 months ago

Last modified 20 months ago

#22346 new enhancement

ToggleDialog: fix maximum height

Reported by: mikeho Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: toggle dialog maximum height Cc:

Description

The height of the windows changes when windows are shown/hidden. JOSM tries to distribute them (evenly). Some windows take up space in height that they don't need, other windows (e.g. Tags / Membership) get too little space in height.

I suggest to fix them by button in two ways:
1) A button for a height such that beyond the minimum required height is not enlarged to show all content.
2) Another button to fix the maximum height - smaller than above as actual shown on screen.

The attached image may clarify this idea.

Attachments (2)

min height.PNG​ (831.5 KB ) - added by mikeho 20 months ago.
window min height illustration
22346.patch​ (4.9 KB ) - added by taylor.smock 20 months ago.
Needs work (UI doesn't work properly when 2 components are maximized, UI does not work properly when multiple dialogs are not collapsed)

Download all attachments as: .zip

Change History (5)

by mikeho, 20 months ago

Attachment: min height.PNG​ added

window min height illustration

comment:1 by skyper, 20 months ago

Type: task → enhancement

comment:2 by skyper, 20 months ago

Keywords: toggle dialog added; Window removed
Summary: Window: fix maximum height → ToggleDialog: fix maximum height

comment:3 by taylor.smock, 20 months ago

We will probably have to override getMaximumSize in the various subclasses. With that said, the pane is somewhat finicky.

Something that should theoretically work doesn't (the minimum size is a problem). My minimal patch does not work correctly, and I'd have to figure out why it isn't working.

by taylor.smock, 20 months ago

Attachment: 22346.patch​ added

Needs work (UI doesn't work properly when 2 components are maximized, UI does not work properly when multiple dialogs are not collapsed)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to mikeho.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.