Modify

Opened 14 months ago

Closed 4 months ago

Last modified 4 months ago

#22279 closed enhancement (fixed)

[Patch] Add new split mode for quick splitting of ways

Reported by: Woazboat Owned by: team
Priority: normal Milestone: 23.06
Component: Core Version:
Keywords: split, mode Cc:

Description (last modified by Woazboat)

Add a new mode for quick splitting of ways by selecting split points via mouse click.
Ambiguous split actions can be resolved by choosing the correct way in a popup dialog or by selecting the targeted way beforehand.
Filters can be used to narrow down which ways are considered for splitting (e.g. filter for highway=* if you only want to split roads)

https://github.com/JOSM/josm/pull/96
https://patch-diff.githubusercontent.com/raw/JOSM/josm/pull/96.patch


Attachments (1)

josm_split_action.gif (95.0 KB) - added by Woazboat 14 months ago.

Download all attachments as: .zip

Change History (7)

Changed 14 months ago by Woazboat

Attachment: josm_split_action.gif added

comment:1 Changed 14 months ago by Woazboat

Description: modified (diff)

comment:2 Changed 14 months ago by Woazboat

For now only splitting at preexisting nodes is implemented. Adding new nodes into way segments and splitting at those is on the todo list.

I re-used the icon for the split way action for the mode. Maybe this could be replaced with a more illustrative one (e.g. a pair of scissors over a way)

comment:3 Changed 14 months ago by Woazboat

Description: modified (diff)

comment:4 Changed 14 months ago by Woazboat

This is somewhat similar to the knife tool in the auto-tools plugin (https://github.com/JOSM/auto-tools#knife-tool), but I think this is useful enough to be implemented in the core

comment:5 Changed 4 months ago by taylor.smock

Resolution: fixed
Status: newclosed

In 18759/josm:

Fix #22279: Add new split mode for quick splitting of ways (patch by Woazboat, modified)

Modifications are as follows:

  • Simplify/inline some variables
  • Move an inner class used only in a class that it is not in into the appropriate class
  • Fix a pre-existing bug where InputEvent.META_MASK would not be mapped to InputEvent.META_DOWN_MASK
  • Override some additional methods in SplitMode (layerIsSupported and getModeHelpText)

comment:6 Changed 4 months ago by taylor.smock

Milestone: 23.06

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.