Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22246 closed defect (fixed)

SlovakiaSpecificRules does not use `fixChangeKey` properly.

Reported by: taylor.smock Owned by: team
Priority: normal Milestone:
Component: External rule Version:
Keywords: Cc: Filip009

Description

Rule is located at wiki:Rules/SlovakiaSpecificRules .

fixChangeKey requires a new=>old mapping. Example:
fixChangeKey: layer=>level;. This will change layer=1 to level=1.

See wiki:Help/Validator/MapCSSTagChecker#Syntax for more information (and alternatives). If you want to remove the layer tag, use fixRemove: layer;

Attachments (0)

Change History (3)

comment:1 by Filip009, 3 years ago

Resolution: fixed
Status: newclosed

fixed, thank you for finding that issue

Last edited 3 years ago by Filip009 (previous) (diff)

comment:2 by taylor.smock, 3 years ago

Thank you. Minor issue (I don't know if Slovakia has the same understanding of osmwiki:Key:layer tags), should

/*
* tunnel without layer
*/
*[tunnel][!layer]{
throwWarning: tr("Are you sure tunnel is not crossing anything?");
fixAdd: "layer=1";
}

be

/*
* tunnel without layer
*/
*[tunnel][!layer]{
throwWarning: tr("Are you sure tunnel is not crossing anything?");
fixAdd: "layer=-1";
}

Anyway, thank you for fixing the issue (I saw the problem on https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/7781/jdk=JDK8/testReport/junit/org.openstreetmap.josm.gui.preferences.validator/ValidatorTagCheckerRulesPreferenceTestIT/Slovakia_specific_rules___https___josm_openstreetmap_de_wiki_Rules_SlovakiaSpecificRules/ ).

comment:3 by Filip009, 3 years ago

Yes, you're right. I just copied it from bridge :D, sorry.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.