validator : unclosed way for sport=running (on a leisure=track)

[marc_marc]

context :
Athletics tracks are usually either oval or oval-shaped with a starting end (a kind of P) or a straight line.
the first case does not raise any problems for the validator
for the 2nd and 3rd, the validator indicates that sport=running should only be used on a closed way.
this is neither the case in reality nor what the wiki suggests.

What steps will reproduce the problem?

1. draw a P or a straight line
2. add leisure=track sport=running
3. run the validator

What is the expected result?

no warning, no error

What happens instead?

validator complain about unclosed way for sport=running

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-07-07 23:02:39 +0200 (Thu, 07 Jul 2022)
Build-Date:2022-07-08 01:30:57
Revision:18513
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18513 fr) Linux CentOS Linux release 7.9.2009 (Core)
Memory Usage: 432 MB / 1717 MB (111 MB allocated, but free)
Java version: 1.8.0_332-b09, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: fr_CH.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: fr_CH
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME-Classic:GNOME
Java package: java-1.8.0-openjdk:x86_64-1.8.0.332.b09
WebStart package: icedtea-web:x86_64-1.7.1
VM arguments: [-Dicedtea-web.bin.name=javaws.itweb, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb]
Dataset consistency test: No problems found

Plugins:
+ ImproveOsm (215)
+ Mapillary (2.0.0-beta.14)
+ apache-commons (35924)
+ apache-http (35924)
+ areaselector
+ austriaaddresshelper (1597341117)
+ cadastre-fr (35893)
+ conflation (0.6.9)
+ continuosDownload (99)
+ ejml (35924)
+ geotools (35959)
+ jackson (35958)
+ jaxb (35952)
+ jna (35924)
+ jts (35976)
+ log4j (35924)
+ opendata (35984)
+ pt_assistant (1ff2e15)
+ reverter (35999)
+ scripting
+ todo (30306)
+ utilsplugin2 (36001)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://raw.github<user.name>content.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1

Last errors/warnings:
- 00013.196 W: Le greffon scripting nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00013.197 W: Le greffon areaselector nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00025.570 E: Impossible de trouver l'image "bus.png"
- 00118.854 W: java.net.SocketTimeoutException: Read timed out. Cause : java.net.SocketTimeoutException: Read timed out
- 00131.835 W: JCS - Silent failure during download: https://tile.openstreetmap.org/19/270483/188265.png
- 00135.362 W: JCS - Silent failure during download: https://tile.openstreetmap.org/19/270487/188263.png
- 00136.416 W: JCS - Silent failure during download: https://tile.openstreetmap.org/19/270485/188263.png
- 00147.908 W: JCS - Silent failure during download: https://tile.openstreetmap.org/19/270487/188267.png

[taylor.smock]

Looking at source:trunk/resources/data/defaultpresets.xml@HEAD:5140-5148#L5140​, it looks like we have set it as valid in the preset. However, it appears source:trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java@HEAD:154-155#L154​ does not exclude sport=running from the check.

• ​osmwiki:Tag:leisure=track (unclosed way is OK)
• ​osmwiki:Tag:sport=running (unclosed way is OK)

Both wiki pages have had the unclosed way as a possibility for > 2 years.

[taylor.smock]

In 18521/josm:

Fix #22225: Don't warn about sport=running on unclosed ways

[Klumbumbus]

In 18533/josm:

see #22225 - Draw unclosed leisure=track sport=running without area style