[PATCH][GitHub] NPE in DataSetChangesetBuilder#mergeBounds

[anonymous]

What steps will reproduce the problem?

1. Entered changeset id
2. clicked display changeset
3. prompted bug report

What is the expected result?

To see the changes that were made in the changeset

What happens instead?

Bug report window showed up

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-07-07 23:02:39 +0200 (Thu, 07 Jul 2022)
Revision:18513
Build-Date:2022-07-08 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18513 en) Mac OS X 12.4
OS Build number: macOS 12.4 (21F79)
Memory Usage: 1224 MB / 2048 MB (333 MB allocated, but free)
Java version: 11.0.15+10-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69733632 1440×900 (scaling 2.00×2.00) Display 188945226 1920×1080 (scaling 1.00×1.00) Display 188945225 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-beta.13-SNAPSHOT)
+ apache-commons (35924)
+ apache-http (35924)
+ auto_tools (81)
+ buildings_tools (35997)
+ changeset-viewer (v0.0.4)
+ continuosDownload (99)
+ graphview (35976)
+ jna (35924)
+ osm-obj-info (66)
+ reverter (35999)
+ rex (53)
+ utilsplugin2 (36001)

Tagging presets:
+ /Applications/JOSM-Buddy/assets/presets/heading.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ ${HOME}/Desktop/Paintstyle:validator checks/Clingstone/Test styles/Current_Kaart_style copy.mapcss
- ${HOME}/Desktop/Paintstyle:validator checks/Clingstone/Test styles/Name-en_test.mapcss
+ https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Overlapping%20Ways.mapcss
- ${HOME}/Desktop/Paintstyle:validator checks/Clingstone/Test styles/Custom_layer_style.mapcss
- ${HOME}/Desktop/Paintstyle:validator checks/Clingstone/QC Styles/New Test QC.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart_QC_Quandary.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart-Styles.mapcss
- ${HOME}/Desktop/Paintstyle:validator checks/applepaintstyles-main/main_street.mapcss

Validator rules:
+ https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.clingstone.validator.mapcss
+ /Applications/JOSM-Buddy/assets/validators/forbidden-tag-check.validator.mapcss
- https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.indonesiaNames.validator.mapcss
- https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.durazno.validator.mapcss
- ${HOME}/Desktop/Paintstyle:validator checks/Clingstone/kaart.malaysiaNames.validator.mapcss
- ${HOME}/Desktop/Paintstyle:validator checks/Clingstone/Test styles/Kaart .test.validator.mapcss

Last errors/warnings:
- 26674.429 E: Invalid JSON: {}
- 26674.429 E: Invalid JSON: {}
- 26674.430 E: Invalid JSON: {}
- 26674.430 E: Invalid JSON: {}
- 26674.431 E: Invalid JSON: {}
- 26674.431 E: Invalid JSON: {}
- 26674.431 E: Invalid JSON: {}
- 26674.432 E: Invalid JSON: {}
- 26674.432 E: Invalid JSON: {}
- 26674.444 E: Handled by bug report queue: java.lang.NullPointerException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-1 (25) of JOSM
java.lang.NullPointerException
	at org.openstreetmap.josm.data.Bounds.extend(Bounds.java:391)
	at org.openstreetmap.josm.plugins.changeset.util.DataSetChangesetBuilder.mergeBounds(DataSetChangesetBuilder.java:178)
	at org.openstreetmap.josm.plugins.changeset.util.DataSetChangesetBuilder.mergeBounds(DataSetChangesetBuilder.java:169)
	at org.openstreetmap.josm.plugins.changeset.util.DataSetChangesetBuilder.buildRelation(DataSetChangesetBuilder.java:224)
	at org.openstreetmap.josm.plugins.changeset.util.DataSetChangesetBuilder.build(DataSetChangesetBuilder.java:94)
	at org.openstreetmap.josm.plugins.changeset.util.ChangesetController.getChangeset(ChangesetController.java:30)
	at org.openstreetmap.josm.plugins.changeset.ChangesetDialog.printMap(ChangesetDialog.java:156)
	at org.openstreetmap.josm.plugins.changeset.ChangesetDialog$1.actionPerformed(ChangesetDialog.java:111)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6635)
	at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
	at java.desktop/java.awt.Component.processEvent(Component.java:6400)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5011)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4547)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[taylor.smock]

PR at ​https://github.com/JOSM/changeset-viewer/pull/10

[taylor.smock]

Ticket #22252 has been marked as a duplicate of this ticket.

[taylor.smock]

Ticket #20794 has been marked as a duplicate of this ticket.

[taylor.smock]

Ticket #20216 has been marked as a duplicate of this ticket.

[taylor.smock]

@stoecker: I hate to bug you again, but it looks I don't have write access to the ​changeset-viewer repository.

[taylor.smock]

In 36018/osm:

changeset-viewer (dist)

• Reduce CPU usage during map paint
• Make colours configurable
• Avoid blocking UI on changeset download
• Authenticate against OSMCha (user input required)
• Fix #22209: NPE in DataSetChangesetBuilder#mergeBounds