Same error code 1708 for two different problems

[GerdP]

What steps will reproduce the problem?

See ticket:21825#comment:74 to ticket:21825#comment:77

Please provide any additional information below. Attach a screenshot if possible.

It should be safe to just change the code for the "empty relation" error since probably no user would want to ignore that.

Revision:18463
Build-Date:2022-05-30 10:23:53

Identification: JOSM/1.5 (18463 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19044)
Memory Usage: 385 MB / 1972 MB (227 MB allocated, but free)
Java version: 17.0.3+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18463, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]

Plugins:
+ apache-commons (35924)
+ buildings_tools (35978)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (35959)
+ imagery-xml-bounds (35976)
+ jackson (35958)
+ jaxb (35952)
+ jts (35976)
+ o5m (35893)
+ opendata (35910)
+ pbf (35978)
+ poly (35976)
+ reltoolbox (35976)
+ reverter (35980)
+ undelete (35893)
+ utilsplugin2 (35970)

Validator rules:
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ c:\josm\core\resources\data\validator\unnecessary.mapcss
+ d:\java_tools\JOSM\mygeometry.mapcss

Last errors/warnings:
- 00000.803 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.806 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00001.470 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[GerdP]

In 18506/josm:

fix #22187, see #21825: Same error code 1708 for two different problems
I introduced this annoying bug with r14990 and it probably caused lots of empty relations since users where not warned when they ignored the less important message "Role of relation member does not match template expression"

[GerdP]

In 18507/josm:

see #22187, see 21825: Same error code 1708 for two different problems
fix unit test