Add 'man_made=quay' to ferry route connection check

[tpikonen]

Currently the geometry check for ferry routes allows the end point of a 'route=ferry' to be either 'amenity=ferry_terminal' or 'man_made=pier'. Some ferry routes also depart from a 'man_made=quay', (​example), so it should also be allowed in the check.

Revision:18463
Is-Local-Build:false
Build-Date:1970-01-05 04:23:22
Debian-Release:0.0.svn18463+dfsg-1
Build-Name:Debian

[taylor.smock]

Looking at ​osmwiki:Tag:man_made=quay, the meaning appears to not have been significantly modified since 2015.

resources/data/validator/geometry.mapcss

@@ -405 +405 @@
 way[man_made=pier] > node {
   set node_in_terminal_pier;
 }
-way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
-way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
+way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier][man_made!=quay]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
+way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier][man_made!=quay]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
   throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
 }

[Klumbumbus]

I wonder if there should always be amenity=ferry_terminal mapped anyway. In the mentioned example node ​https://www.openstreetmap.org/node/6560047680.
Even the current exclusion of man_made=pier is questionable (although it seems I made some deeper data analysis back in the days ticket:15097#comment:8)

[taylor.smock]

You are probably right. The only reason I was open to making the change was due to the exclusion of man_made=pier.

@tpikonen: Do you know of any real-world instances where a ferry departure point should not be tagged as amenity=ferry_terminal?

@GerdP: I suspect we should probably remove the exclusion of man_made=pier.

[tpikonen]

Calling a piece of shoreline with mooring and a lowered section (like in the example I gave) a ferry terminal is a bit excessive. Across the bay there you can see a real ferry terminal for RORO ships with 1000s of passengers, also tagged as 'amenity=ferry_terminal'.

But there is of course the point that ferries taking passengers always end on some kind of ferry terminal, so I'm not really against changing the check to be more restrictive.