Modify ↓

Opened 3 years ago

Closed 3 years ago

#22116 closed defect (fixed)

[PATCH] Wikipedia tests have been failing

Reported by: taylor.smock Owned by: floscher
Priority: normal Milestone:
Component: Plugin wikipedia Version:
Keywords: Cc:

Description (last modified by taylor.smock)

https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/2170/jdk=JDK11/testReport/junit/org.wikipedia/WikipediaAppTest/testForQuery/

It looks like ​https://www.wikidata.org/wiki/Q40 was changed. Updating the description should fix the test failure.

Relevant links:

  • test/unit/org/wikipedia/WikipediaAppTest.java 

    diff --git a/test/unit/org/wikipedia/WikipediaAppTest.java b/test/unit/org/wikipedia/WikipediaAppTest.java
index 6ad8029..639a044 100644
    a b public class WikipediaAppTest {  
    9292        assertThat(de.get(0).label, is("Österreich"));
    9393        assertThat(de.get(0).description, is("Staat in Mitteleuropa"));
    9494        assertThat(en.get(0).label, is("Austria"));
    95         assertThat(en.get(0).description, is("country in Europe"));
     95        assertThat(en.get(0).description, is("country in Central Europe"));
    9696    }
    9797
    9898    @Test

PR here: ​https://github.com/JOSM/wikipedia/pull/6

Attachments (0)

Change History (3)

comment:1 by taylor.smock, 3 years ago

Summary: Wikipedia tests have been failing → [PATCH] Wikipedia tests have been failing

comment:2 by taylor.smock, 3 years ago

Description: modified (diff)

comment:3 by taylor.smock, 3 years ago

Resolution: → fixed
Status: new → closed

Merged in ​https://github.com/JOSM/wikipedia/commit/7b4ef90ebfff8c22593a1658095afd51f6e8a6b7

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain floscher.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.