[PATCH] Avoid allocations for point objects (Nodes) in QuadBuckets

[taylor.smock]

src/org/openstreetmap/josm/data/osm/QuadBuckets.java

@@ -11 +11 @@
 import java.util.stream.IntStream;
 
 import org.openstreetmap.josm.data.IQuadBucketType;
+import org.openstreetmap.josm.data.coor.ILatLon;
 import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.data.coor.QuadTiling;
 import org.openstreetmap.josm.tools.Logging;
@@ -173 +174 @@
         }
 
         boolean matches(final T o, final BBox searchBbox) {
+            // Avoid allocations for point (AKA Node) objects
+            if (o instanceof ILatLon) {
+                return searchBbox.contains((ILatLon) o);
+            }
             return o.getBBox().intersects(searchBbox);
         }
 

This reduces the allocations for Nodes in QuadBuckets.QBLevel#matches by 80% (we're no longer creating a new BBox every time). The remaining cost is from ArrayList#grow.

Unfortunately, this isn't a major perf win (it is dwarfed by other things) but it does shave a percentage point or two off of the render path allocations.

[taylor.smock]

In 18465/josm:

Fix #22106: Avoid allocations for point objects in QuadBuckets

Nodes do not keep their bboxes in memory (to reduce overall memory usage).
This does mean that every time someone searches a quadbucket for nodes, we
have to recreate the BBox for every node in a quadbucket leaf. This is a
significant number of allocations that are unnecessary (~80% of the memory
allocations from QuadBuckets#search for nodes is from the creation of
temporary bboxes). The remaining cost for the search is from List#grow calls.