Modify ↓

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#22080 closed defect (fixed)

[RFC PATCH] UploadHooks modifyChangesetTags should be called prior to showing the user the upload dialog for non-late hooks

Reported by: CjMalone Owned by: team
Priority: normal Milestone: 22.06
Component: Core Version:
Keywords: Cc: taylor.smock

Description

I think the current system of adding tags after the user confirms the upload is unexpected. Ideally any changeset tags would be visible (and probably editable) to the user.

Attachments (0)

Change History (3)

comment:1 Changed 16 months ago by taylor.smock

Summary: UploadHooks modifyChangesetTags should be called prior to showing the user the upload dialog for non-late hooks → [RFC PATCH] UploadHooks modifyChangesetTags should be called prior to showing the user the upload dialog for non-late hooks

This partially duplicates #20025.

See attachment:20025.core.3.patch:ticket:20025​ .
As noted in comment:2:ticket:20025, I was leaving the patch up for comments for a week or so.

comment:2 Changed 16 months ago by taylor.smock

Resolution: → fixed
Status: new → closed

In 18467/josm:

Fix #20025, #22080: Notify users when changeset tags are programmatically modified

This only works for non-late upload hooks.

comment:3 Changed 16 months ago by taylor.smock

Milestone: → 22.06

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.