[RFC PATCH] Add `nohousenumber` to the address preset

[ma-rt-in]

I request that the internal preset for address be expanded to include the following points:
noaddress=yes
nohousenumber=yes

Please also adapt the JOSM checker accordingly.

Here are the links to taginfo and the wiki
​https://taginfo.openstreetmap.org/keys/?key=noaddress
​https://wiki.openstreetmap.org/wiki/Key:noaddress

​https://wiki.openstreetmap.org/wiki/Key:nohousenumber
​https://taginfo.openstreetmap.org/keys/?key=nohousenumber

[taylor.smock]

I presume you want us to modify source:trunk/resources/data/defaultpresets.xml@18449:9105-9129#L9105​ .

Having looked at the UI for addresses, I'm not seeing a good place to add it. I also don't think we currently have a way to specify that one preset element conflicts with another preset element (I could be wrong about this), so someone could check the box for noaddress/nohousenumber, and then add address information (addr:housenumber/addr:housename).

[Klumbumbus]

Replying to taylor.smock:

Having looked at the UI for addresses, I'm not seeing a good place to add it.

We already use noref and noname on some major road presets simply with a checkbox below the ref/name text box e.g.: source:trunk/resources/data/defaultpresets.xml@18449:742-746#L738​

I also don't think we currently have a way to specify that one preset element conflicts with another preset element (I could be wrong about this), so someone could check the box for noaddress/nohousenumber, and then add address information (addr:housenumber/addr:housename).

This is handled then by the validator and if "Run data validator on user input" (taggingpreset.validator) is set to true (default is false though) then such an error is even already indicated in the preset window with the yellow warning icon.

(Btw. I just noticed that only the validator test for name=* + noname=yes is present, but the one for ref=* + noref=yes is missing.)

[taylor.smock]

Something like this will probably work (and we should probably add a mapcss check):

resources/data/defaultpresets.xml

@@ -9107 +9107 @@
             <space />
             <text key="addr:housenumber" text="House number" match="key" auto_increment="-2,-1,+1,+2" />
             <text key="addr:street" text="Street name" use_last_as_default="force" match="key" alternative_autocomplete_keys="name" />
+            <check key="nohousenumber" text="House has no address" disable_off="true"/>
             <optional>
                 <text key="addr:city" text="City name" use_last_as_default="force" match="key" />
                 <text key="addr:postcode" text="Post code" use_last_as_default="force" match="key" />

I think we can probably ignore noaddress -- most of the usage came in a very short spike (probably an import) in January 2021.
EDIT: For reference, ~35k out of ~44k tags are in ​Centre County, Pennsylvania.

[taylor.smock]

resources/data/defaultpresets.xml

@@ -9107 +9107 @@
             <space />
             <text key="addr:housenumber" text="House number" match="key" auto_increment="-2,-1,+1,+2" />
             <text key="addr:street" text="Street name" use_last_as_default="force" match="key" alternative_autocomplete_keys="name" />
+            <check key="nohousenumber" text="House has no address" disable_off="true"/>
             <optional>
                 <text key="addr:city" text="City name" use_last_as_default="force" match="key" />
                 <text key="addr:postcode" text="Post code" use_last_as_default="force" match="key" />

resources/data/validator/addresses.mapcss

@@ -44 +44 @@
   assertMatch: "way addr:housenumber=unknown";
   assertMatch: "way addr:housenumber=Palace of Westminster";
   assertMatch: "way addr:housenumber=S/N";
-}
- No newline at end of file
+}
+
+*[addr:housenumber][nohousenumber?] {
+  throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
+  group: tr("suspicious tag combination");
+  assertMatch: "way addr:housenumber=1 nohousenumber=yes";
+  assertNoMatch: "way addr:housenumber=2";
+}

A better spot for the validator might be source:trunk/resources/data/validator/combinations.mapcss​

[Klumbumbus]

In 18460/josm:

fix #22076 - Add nohousenumber=yes checkbox, warn about combinations of nohousenumber=yes + addr:housenumber=* and noref=yes + ref=* (based on patch by taylor.smock)