Modify ↓

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#22074 closed enhancement (fixed)

[Patch] Make opening hours parsing more lenient in strict mode

Reported by: SimonPoole Owned by: team
Priority: normal Milestone: 22.05
Component: Core Version:
Keywords: opening_hours Cc:

Description

See the attached patch.

Attachments (2)

0001-Disable-time-strict-mode.patch​ (1.8 KB ) - added by SimonPoole 4 years ago.
22074.patch​ (1.8 KB ) - added by taylor.smock 4 years ago.
Add advanced preference setting to enable/disable lenient mode

Download all attachments as: .zip

Change History (8)

by SimonPoole, 4 years ago

Attachment: 0001-Disable-time-strict-mode.patch​ added

comment:1 by taylor.smock, 4 years ago

Stupid question:
Can you think of any reason to pass true in to OpeningHoursParser#rules(boolean, boolean)?

If so, I'd prefer to have a preference setting that users can override.

by taylor.smock, 4 years ago

Attachment: 22074.patch​ added

Add advanced preference setting to enable/disable lenient mode

comment:2 by taylor.smock, 4 years ago

Keywords: opening_hours added
Summary: Make opening hours parsing more lienent in strict mode → Make opening hours parsing more lenient in strict mode

comment:3 by anonymous, 4 years ago

Summary: Make opening hours parsing more lenient in strict mode → [Patch] Make opening hours parsing more lenient in strict mode

comment:4 by SimonPoole, 4 years ago

There is already a preference for strict / non-strict mode overall, I don't see much value in adding a further pref for a sub-variant of the strict mode. In particular, depending on feedback, the option might go away in a future version in any case.

comment:5 by taylor.smock, 4 years ago

Resolution: → fixed
Status: new → closed

In 18453/josm:

Fix #22074, #22075: OpeningHoursParser updates (patch by SimonPoole)

Disable time strict mode

This change makes parsing in strict mode slightly more lenient with
respect to time ranges that extend over midnight, with other words this
will no longer complain if non-conflicting long time ranges are used
instead of using the extended time syntax.


Parsing in non-strict mode remains unchanged.

Update OpeningHoursParser to 0.27.0

The update fixes an issue with parsing open ended date ranges followed
by a weekday.

comment:6 by taylor.smock, 3 years ago

Milestone: → 22.05

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.