[RFC PATCH] When `changeset_source` is set via remote control or file load, allow `Automatically obtain source from current layers` to autofill the source tag

[chisomejeh@…]

What steps will reproduce the problem?

1. When I try uploading data to OSM server the imagery layer does not automatically upload even when the box is already checked.

What is the expected result?

The imagery layers should update automatically

What happens instead?

The imagery layer recognises only Bing, even when its not being used.

Please provide any additional information below. Attach a screenshot if possible.

Revision:18427
Build-Date:2022-04-05 19:23:14

Identification: JOSM/1.5 (18427 en) Windows 11 64-Bit
OS Build number: Windows 10 Home 2009 (22000)
Memory Usage: 1334 MB / 3044 MB (735 MB allocated, but free)
Java version: 17.0.2+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.nimbus.NimbusLookAndFeel
Screen: \Display0 1366×768 (scaling 1.00×1.00)
Maximum Screen Size: 1366×768
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18427, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ BuildingGeneralization (36)
+ Tracer (35893)
+ apache-commons (35924)
+ apache-http (35924)
+ buildings_tools (35951)
+ imagery_offset_db (35893)
+ jna (35924)
+ mapathoner (1.1.13)
+ mapwithai (1.9.10)
+ turnrestrictions (35893)
+ utilsplugin2 (35951)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://github.com/MissingMaps/josm_styles/archive/master.zip
- https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip
+ %UserProfile%\Documents\applepaintstyles-main.zip

Last errors/warnings:
- 33418.711 W: java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- 33418.711 W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- 33418.711 W: java.net.UnknownHostException: ecn.t2.tiles.virtualearth.net
- 33418.711 W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- 33418.711 W: java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- 33418.712 W: java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- 33418.712 W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- 33419.473 W: java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- 33419.473 W: java.net.UnknownHostException: ecn.t2.tiles.virtualearth.net
- 33419.473 W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net

[chisomejeh@…]

A snip of the error

[taylor.smock]

Looking at the project, ​https://tasks.hotosm.org/projects/12404/tasks, it looks like they have specified the imagery as Bing.

Since the imagery is specified, the Tasking Manager tells JOSM to use that source. (See ​tasking-manager/.../openEditor.js#L182).

We probably ought to allow other sources to be appended to that list automatically.

[taylor.smock]

attachment:22056.patch​ does the following:

• Converts getSourceLayer from BasicUploadSettingsPanel to package-private from private.
• Overrides getChangesetSourceTag in OsmDataLayer to use the set changeset tags
• Overrides the tags set by the data set if upload.source.obtainautomatically is true.

The question for the rest of the team:

• Do we want to override the changeset source tag set by changeset_source in remote control? The documentation states that changeset_source will be the "Source of the changeset". This implies (to me) that it is equal to source in the changeset.

[taylor.smock]

Allow Automatically obtain source from current layers to work when the dataset has a source changeset tag applied

[taylor.smock]

I asked a person involved with the TM, and he expected the source tag to be what was set and what the user used. I'll go ahead and merge the patch Monday, if I don't hear from anyone that the current behavior is expected (with an explanation for why).

[taylor.smock]

In 18457/josm:

Fix #22056: source in the dataset tags overrides automatic sources

This ocurred when changeset_source is set via remote control or file load.