Modify

Opened 3 years ago

Last modified 3 years ago

#22013 new defect

[Patch]Validator should accept denomination=sufi instead of denomination=sufism

Reported by: bxl-forever Owned by: team
Priority: minor Milestone:
Component: Core validator Version:
Keywords: Cc:

Description

Some mosques (amenity=place_of_worship + religion=islam) are linked to sufism.

The data validator accepts "denomination=sufism" but issues an "Unknown property value" warning for denomination=sufi.

It appears to be incoherent with the way other denominations are written.
For instance, sunnism is translated as "denomination=sunni" in OSM. Therefore, sufism should be "denomination=sufi". The wiki use this standard, I suggest we do the same for JOSM.

Attachments (1)

22013.patch (3.2 KB ) - added by GerdP 3 years ago.
patch to add sufi in those places where sunni is mentioned, both are islamic

Download all attachments as: .zip

Change History (5)

comment:1 by GerdP, 3 years ago

Both sufi and sufism are unknown in JOSM, but sufism is not considered as a possible typo of sunni.
The message texts are

Warnings (1)
  Unknown property value - Value 'sufi' for key 'denomination' is unknown, maybe 'sunni' is meant? (1)
Other (1)
  Presets do not contain property value - Value 'sufism' for key 'denomination' not in presets. (1)

Not sure what to do. Taginfo reports 96 usages of denomination=sufi, only 3 for denomination=sufism

Last edited 3 years ago by GerdP (previous) (diff)

by GerdP, 3 years ago

Attachment: 22013.patch added

patch to add sufi in those places where sunni is mentioned, both are islamic

comment:2 by GerdP, 3 years ago

Component: CoreCore validator
Summary: Validator should accept denomination=sufi instead of denomination=sufism[Patch]Validator should accept denomination=sufi instead of denomination=sufism

comment:3 by taylor.smock, 3 years ago

It looks like there may be some controversy over using sufi as a denomination.

See

From wikipedia:Sufism,

Existing in both Sunni and Shia Islam, Sufism is not a distinct sect, as is sometimes erroneously assumed, [...]

So it seems to me that sufism should be in a sub-key for the denomination, but I don't think there are any common sub-keys for denomination. Absent a subkey, it really should be used in conjunction with another muslim denomination (e.g. denomination=sunni;sufi).

Reasoning: I would presume that a sunni practitioner that does not use sufism would be OK with going to a location using sufism to practice the sunni ideology, but would not be OK going to a location using sufism to practice the shia ideology.
(Feel free to correct me if I'm wrong, I only know what the wikis have said).

comment:4 by GerdP, 3 years ago

OK for me. If we don't add sufi to the presets we should add it to the ignoretags.cfg so that it doesn't suggest sunni.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to bxl-forever.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.