[Patch] Improve session workflow / Add "save session"

[Bjoeni]

This patch improves the session workflow by allowing the user to keep one session opened and simply saving changes to that session

• Allow saving the current session that was previously saved ⁽¹⁾
• Add menu "File > Save Session" ⁽²⁾
• Add shortcuts for "Save Session" and "Save Session As..." menus ⁽³⁾
• Convert from *.jos to *.joz if necessary
• Warn if a layer will be removed from the session file that was previously saved ⁽⁴⁾
• allow easily modifying GPX files by keeping the associated file when converting back and forth between GPX and OSM layers (and also, prevent multiple "Converted from:" in the name)

---

Notes:

[1]: The dialog allowing the user to select/deselect layers will not be shown in that case. All layers are saved. The ones with associated files will be referenced, the others will be included in the session file (like the default settings in the "Save Session As..." dialog)

[2]: Personally I think with the new functionality it would make sense to make these menus available in non-expert mode as well. What do you think?

[3]: The default shortcuts are currently as follows:

I think the "Save Session" shortcut makes sense, and the "Save Session As..." shortcut is only logical when compared to the "Save" vs. "Save As..." shortcuts. However that's a relatively long shortcut, so I can also change or remove that. Opinions?

[4]:

[Bjoeni]

Note: The patches #19219, #21813, #21922, #21923 all affect session handling. Whilst I don't think that they conflict, I only tested them all together.

It might make sense to only apply the all.patch for all tickets

---

Edit: The SessionSaveActionTest in this patch does actually depend on #21813.

[stoecker]

Milestone renamed

[taylor.smock]

• (2): I'm generally disinclined to move items from Expert mode in the same patch/patch series where changes to the item occur. I'd prefer to have a separate bug for that. If we had due dates on JOSM trac, I'd set the due date to 6 months from the change to the functionality. This is largely to give Expert mode users a chance to complain ("this makes less sense than before", "it breaks when doing <x>", etc.). Although I've seen at least one set of instructions for new JOSM mappers where they enabled Expert mode (I think this was in some HOT documentation somewhere).
• (3): There are a relatively few number of keyboard shortcuts that (a) make sense and (b) don't conflict with anything else. It is probably about as good as you can get.

[Bjoeni]

Replying to taylor.smock:

• (2): I'm generally disinclined to move items from Expert mode in the same patch/patch series where changes to the item occur. I'd prefer to have a separate bug for that. If we had due dates on JOSM trac, I'd set the due date to 6 months from the change to the functionality. This is largely to give Expert mode users a chance to complain ("this makes less sense than before", "it breaks when doing <x>", etc.). Although I've seen at least one set of instructions for new JOSM mappers where they enabled Expert mode (I think this was in some HOT documentation somewhere).

I completely agree. It's not changed in this patch (yet). 6 months seems like a reasonable timeframe, thanks for the feedback. See #22064

[taylor.smock]

Replying to Bjoeni:

Edit: The SessionSaveActionTest in this patch does actually depend on #21813.

Thanks for the edit -- I was wondering why things weren't applying cleanly, and I had assumed it was due to applying the patches for #19219 and #21922 separately.

Replying to Bjoeni:

I completely agree. It's not changed in this patch (yet). 6 months seems like a reasonable timeframe, thanks for the feedback. See #22064

Thanks for filing a new ticket.

[Bjoeni]

Replying to taylor.smock:

Replying to Bjoeni:

Edit: The SessionSaveActionTest in this patch does actually depend on #21813.

Thanks for the edit -- I was wondering why things weren't applying cleanly, and I had assumed it was due to applying the patches for #19219 and #21922 separately.

Well that too probably. I can provide an updated patch for this one once #21813 ist closed.

[taylor.smock]

In 18466/josm:

Fix #21813: Improve marker handling in sessions and #21923: Improve session workflow/Add "save session" (patch by Bjoeni)

• Allow saving a previously saved session
• Add "File" -> "Save Session"
• Add shortcuts for saving sessions
• Add warning if a layer in a session is being removed when saving over the session
• Improve GPX marker handling