amenity inside amenity should always consider layer tag

[skyper]

What steps will reproduce the problem?

1. Have an area amenity=parking, parking=surface and a node inside the area with amenity=parking, parking=underground, layer=-1
2. Run validator

What is the expected result?

No warning

What happens instead?

Warning: amenity inside amenity - amenity=parking inside amenity=parking

Please provide any additional information below. Attach a screenshot if possible.

As these amenities are two different object in real world with separate entrances and possibly different access restrictions they cannot be mapped as one object.
Maybe the secondary key parking=* could be used.
Mapping both parkings as area with identical tags does not trigger the warning.
See also #14155 and ​https://forum.openstreetmap.org/viewtopic.php?id=74919

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-02-18 08:34:05 +0100 (Fri, 18 Feb 2022)
Revision:18382
Build-Date:2022-02-19 02:31:08
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18382 en) Linux Debian GNU/Linux 11 (bullseye)
Java version: 17.0.2+8-Debian-1deb11u1, Debian, OpenJDK 64-Bit Server VM

[GerdP]

The building inside building test considers the layer.

*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] ∈
area[building][building!~/no|entrance/] {
  throwWarning: tr("Building inside building");

Can't we use the same logic for amenity as well?

[skyper]

I did not take a look at the code but the solution for buildings looks promising.