[WIP patch] Harmonize menu strings style

[gaben]

The strings in the settings consist of multiple styles:

• Capital first letter, rest normal
• Capital first letter, rest normal and dot at the end.
• Capital Some letter, no dot at the end
• Capital Some letter, dot at the end.

In the provided patch I tried to harmonize these. Unfortunately, it affects the translations as well, but they are ugly.

[stoecker]

Dropping the icon comments breaks things.

Also removing the dots in the tooltips is not useful or sensible. The tool tips are sentences and thus also should have a dot. And that change would waste a lot of translation effort for nearly nothing.

Please fix these two then we can look at the remaining ones.

[taylor.smock]

@gaben: Just so you know, one of the things it breaks is source:trunk/scripts/geticons.pl​.

Anyway, are you going to update the patch with @stoecker's feedback, or is this ticket dead?

[gaben]

Thanks, at least I know what I broke. Interestingly I found classes without these comment like "hooks", so I thought they are not essential. Also without them, ​IntelliJ's inline parameter hinting works, which is more important without knowing their real purpose.

I would say half dead. The ticket is about harmonisation. If you think "The tool tips are sentences and thus also should have a dot", I would add dots to tooltips, which will also ruin translations. I get it and agree, but this way strings will never improve.

[taylor.smock]

There are some things I think we could safely apply from your patch. Example: Hightlight -> Highlight.

But for the mass changes add ., I'd be happier if there was some way to link the previous translation, possibly marking it as dirty or something.

It looks like gettext has a fuzzy attribute, and I'd really want to have it set for most of the changes. But I also don't know how fuzzy works with our current system, or if we even set it anywhere.

[stoecker]

In 18416/josm:

text fix, fix #21865

[stoecker]

In 18417/josm:

text fix, fix #21865