WMS and WMTS don't support {apikey}

[stoecker]

To update the mapkey support in JOSM WMS and WMTS must also support the {apikey} placeholder.

[stoecker]

Milestone renamed

[stoecker]

Join milestones

[taylor.smock]

I've tested it with Lantmäteriet Historic Orthophoto 1975 (WMS) and Lantmäteriet Topographic Map (WMTS).

I'm checking error handling now, and then I'll be writing tests -- I don't know how critical this is -- it looks like we've replaced the api keys for those two already, so I'll probably apply it as soon as I see how it handles errors.

[taylor.smock]

In 18371/josm:

fix #21850: WMS and WMTS don't support {apikey}

This adds {apikey} as a valid template for WMS and WMTS.

[stoecker]

Replying to taylor.smock:

it looks like we've replaced the api keys for those two already, so I'll probably apply it as soon as I see how it handles errors.

I reverted (removed) these changes. So currently no active entries exist.

[taylor.smock]

In 18372/josm:

see #21850: WMS and WMTS don't support {apikey}

Add tests for r18371.

[taylor.smock]

Replying to stoecker:

I reverted (removed) these changes. So currently no active entries exist.

We'll be able to re-apply those in a few months. Or as soon as most of the users migrate to the next tested version, anyway.

[stoecker]

It's seems this solution has a big drawback. Hundreds of calls. The function to get the API-Key should only be called once and only if the pattern is found. Probably copy the replace code from TiledWMS class?

I got 13385 calls for "Mapa-Educativo-wms" in a few minutes and this entry doesn't even have an API key.

[taylor.smock]

Replying to stoecker:

It's seems this solution has a big drawback. Hundreds of calls. The function to get the API-Key should only be called once and only if the pattern is found. Probably copy the replace code from TiledWMS class?

Ouch. I'll look into it.

[stoecker]

No problem. The server can handle it without additional costs, as long as it does not exceed 1GBit/s ;-)

[taylor.smock]

In 18378/josm:

see #21850: Fix calls to JOSM server where not apikey is needed

[taylor.smock]

Replying to stoecker:

I got 13385 calls for "Mapa-Educativo-wms" in a few minutes and this entry doesn't even have an API key.

I presume this is for the imagery integration test. That seems like a lot anyway. Are we hammering other people's servers during testing? I should probably look into running the integration tests with a network monitor set up.

[stoecker]

Replying to taylor.smock:

Replying to stoecker:

I got 13385 calls for "Mapa-Educativo-wms" in a few minutes and this entry doesn't even have an API key.

I presume this is for the imagery integration test.

Some Google service (xxx.googleusercontent.com), so probably not the integration test.

That seems like a lot anyway.

I'd say probably one call per map tile?

Are we hammering other people's servers during testing? I should probably look into running the integration tests with a network monitor set up.

Depends. Yes and no. The map integration tests do a lot network I/O, but for each related services that's minimal. Also that's the reason why these test are run relatively seldom.

Also that's one of the reasons why JOSM server acts as cache for remote data (e.g. geofabrik-index-v1-nogeom.json), so we don't hammer other servers.

But surely it's relatively easy to do harm with network I/O.