Modify

Opened 6 months ago

Last modified 68 minutes ago

#21836 new enhancement

voltage-high and voltage-low keys replacement on power transformers

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 22.08
Component: Core validator Version:
Keywords: power, transformer, voltages Cc:

Description

Dear maintainers,

In #15367, deprecation of special voltages keys voltage-high and voltage-low has been forgotten.
It follows the approval of https://wiki.openstreetmap.org/wiki/Proposed_features/Transformer_extension_proposal in 2017

Wiki is up to date with dedicated pages for replacement guidelines.

Is it possible to raise a warning, at least like voltage=* in combination with power=transformer/transformer please?

By default, voltage-high and voltage-low are respectively replaceable by voltage:primary and voltage:secondary
When combined to transformer=generator, voltage-high and voltage-low are respectively replaceable by voltage:secondary and voltage:primary (primary and secondary are inverted).

Keep up with good work :)

Attachments (0)

Change History (9)

comment:1 Changed 6 months ago by gaben

Isn't the primary winding is on the input, while the rest is on the output side, regardless of the voltage level? So changing keys require a bit of luck to get it right.

Last edited 6 months ago by gaben (previous) (diff)

comment:2 Changed 6 months ago by francois.lacombe

That's right.
It's mostly correct to state voltage-high = voltage:primary, except in power plants with transformers used to step up voltage to transmit power over the grid (where voltage-low is the primary voltage).

transformer=generator can be added on step up transformer and then JOSM could adapt its fix recommendation.

JOSM could also propose to add transformer=generator when primary < secondary voltage, if available.

comment:3 Changed 6 months ago by francois.lacombe

https://wiki.openstreetmap.org/wiki/Key:voltage:primary

A good side improvement would be to warn about some voltage:primary (and respectively voltage:secondary, voltage:tertiary...) usage on following situations:

  • Used on areas, relations (wiki states it's only valid on nodes)
  • Missing required transformer=* key.

As to avoid situations like this one, using voltage:primary to distinguish substation's voltages.
https://www.openstreetmap.org/way/88462768

comment:4 Changed 2 days ago by Klumbumbus

In 18535/josm:

see #21836 - Add some power/voltage validation rules:

  • voltage:primary/secondary/tertiary without transformer
  • voltage:primary/secondary/tertiary on a way
  • voltage:primary/secondary/tertiary not in correct number format (should be in volts with no units/delimiter/spaces)
  • don't warn about unknown numeric values of voltage:primary/secondary/tertiary
  • transformer together with voltage on nodes
  • voltage:secondary is lower than voltage:primary on transformer=generator
  • deprecate voltage-high and voltage-low in favor of voltage:primary/secondary

comment:5 in reply to:  2 Changed 2 days ago by Klumbumbus

Replying to francois.lacombe:

JOSM could also propose to add transformer=generator when primary < secondary voltage, if available.

I think this is a bit risky, since the voltage:primary/secondary tags could be mixed up. Instead I added a warning when voltage:secondary is lower than voltage:primary on transformer=generator. Is the other way round also a safe error? i.e. voltage:secondary is higher than voltage:primary on a transformer=* which is not a transformer=generator

comment:6 Changed 2 days ago by Klumbumbus

Milestone: 22.07

Do you think something important was missing in r18535?

comment:7 Changed 2 days ago by Klumbumbus

In 18536/josm:

see #21836 - Improve error messages (use only key instead of whole tag)

comment:8 Changed 28 hours ago by skyper

Milestone: 22.0722.08

22.07 was released but trac is not up to date.

comment:9 in reply to:  8 Changed 68 minutes ago by taylor.smock

Replying to skyper:

22.07 was released but trac is not up to date.

Yep. I think either stoecker/Don-vip have to close the milestone. Or someone else with the appropriate privileges. I did the release, but I cannot close milestones ( as specified on wiki:DevelopersGuide/Releasing ). It looks like someone has gone in and marked the milestone completed on the appropriate day.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to francois.lacombe
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.