Modify

Opened 4 years ago

Closed 4 months ago

#21802 closed defect (fixed)

Exclude georgian wiki pages "wikipedia=ka:xxx" from "wikipedia page title should have first letter capitalized"

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report georgian wikipedia Cc:

Description

What steps will reproduce the problem?

  1. Adding a wikipedia=ka:* tag

What is the expected result?

To not be flagged as an error

What happens instead?

Is flagged as an error since it expects a first letter capitalized

Please provide any additional information below. Attach a screenshot if possible.

I reported this issue on the Osmose Github, they said to report it here: https://github.com/osm-fr/osmose-backend/issues/1394

Attachments (0)

Change History (4)

comment:1 by skyper, 4 years ago

Component: CoreCore validator
Keywords: georgian wikipedia added

comment:2 by Klumbumbus, 3 years ago

The example from the Osmose issue is wikipedia=ka:ბირკიანი which is not flagged in JOSM. I guess this is because JOSM checks by \p{Ll} in the rule in wikipedia.mapcss that there is no uppercase variant. It seems Osmose is not parsing it correctly. (Could someone confirm please?)

However, the rule exludes jbo, while https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php currently lists at wgCapitalLinks:
default, jbowiki, pwnwiki, szywiki, taywiki, wiktionary
So the JOSM list should be updated!?

current rule in wikipedia.mapcss:

/* All wikipedias except "jbo" automatically capitalize first letter of the page title.
   To see the latest list, see <https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php>
   and look for 'wgCapitalLinks' setting. */
*[wikipedia =~ /^[-a-zA-Z]{2,12}:\p{Ll}/][wikipedia !~ /^jbo:/][wikipedia !~ /(?i)^[-a-z]{2,12}:https?:/] {
  throwWarning: tr("wikipedia page title should have first letter capitalized");
  fixAdd: concat("wikipedia=", get(regexp_match("(?i)^([-a-z]+:)(.)(.*)$", tag("wikipedia")),1), upper(get(regexp_match("(?i)^([-a-z]+:)(.)(.*)$", tag("wikipedia")),2)), get(regexp_match("(?i)^([-a-z]+:)(.)(.*)$", tag("wikipedia")),3));
  assertMatch: "node wikipedia=en:foo";
  assertNoMatch: "node wikipedia=en:Foo";
  assertMatch: "node wikipedia=ru:абв";
  assertNoMatch: "node wikipedia=ru:Абв";
}

comment:3 by anonymous, 3 years ago

Georgian alphabet doesn't have upcase and lowercase letters: https://en.wikipedia.org/wiki/Georgian_scripts
so it should be excluded as jbo is.

comment:4 by Famlam, 4 months ago

Resolution: fixed
Status: newclosed

This was fixed with r19362

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.