Modify ↓
Opened 3 years ago
Closed 3 years ago
#21752 closed enhancement (fixed)
Wikidata item name in properties is always gray
Reported by: | ygramul | Owned by: | floscher |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Plugin wikipedia | Version: | |
Keywords: | template_report wikidata color | Cc: |
Description
What steps will reproduce the problem?
- Open the properties panel for an item that has any Wikidata tag
- Have the Wikipedia plugin installed. The properties table will now show the Wikidata item name after the Q298374 identifier
- Select the row with the Wikidata tag.
What is the expected result?
The item name remains legible.
What happens instead?
Since the item name always has the same color, contrast with some selection backgrounds can be very poor. Depending on the Look & Feel, of course.
Unselected: http://hypftier.de/temp/2022-01-07_231251.jpg
Selected: http://hypftier.de/temp/2022-01-07_231731.jpg
Please provide any additional information below. Attach a screenshot if possible.
URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022) Build-Date:2022-01-02 20:26:19 Revision:18360 Relative:URL: ^/trunk Identification: JOSM/1.5 (18360 en) Windows 10 64-Bit OS Build number: Windows 10 Pro 2009 (19043) Memory Usage: 1868 MB / 5444 MB (1485 MB allocated, but free) Java version: 1.8.0_292-b10, AdoptOpenJDK, OpenJDK 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel Screen: \Display0 1920×1200 (scaling 1.00×1.00) Maximum Screen Size: 1920×1200 Best cursor sizes: 16×16→32×32, 32×32→32×32 Environment variable LANG: en System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: en_US Numbers with default locale: 1234567890 -> 1234567890 Dataset consistency test: No problems found Plugins: + BuildingGeneralization (36) + CADTools (1008) + FastDraw (35893) + HouseNumberTaggingTool (35893) + Mapillary (2.0.0-alpha.50) + OpeningHoursEditor (35893) + PicLayer (1.0.1) + RoadSigns (35893) + Tracer2 (35893) + apache-commons (35893) + apache-http (35893) + auto_tools (81) + buildings_tools (35893) + continuosDownload (99) + contourmerge (v0.1.8) + ejml (35893) + geotools (35893) + imagery_offset_db (35893) + jaxb (35893) + jna (35893) + jogl (1.2.3) + jts (35893) + kendzi3d (1.0.205) + kendzi3d-resources (0.0.2) + log4j (35893) + measurement (35893) + opendata (35893) + reltoolbox (35893) + scripting (30798) + tageditor (35893) + terracer (35893) + turnlanes (35893) + turnlanes-tagging (v0.0.5) + turnrestrictions (35893) + utilsplugin2 (35893) + wikipedia (605) Tagging presets: + https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip Map paint styles: + https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/DE.zip + https://josm.openstreetmap.de/josmfile?page=Styles/Building_Levels_Labels&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Direction&zip=1 + https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1 + https://github.com/igitov/forest-josm-style/archive/master.zip + https://pasharm.github.io/New_basic_style_for_JOSM/New_basic_style.mapcss + https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1 + https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss + https://josm.openstreetmap.de/josmfile?page=Styles/Direction&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1 Last errors/warnings: - 00009.943 W: Unable to request certificate of https://grca.nat.gov.tw
Attachments (0)
Change History (3)
comment:2 by , 3 years ago
Component: | Core → Plugin wikipedia |
---|---|
Keywords: | wikidata color added |
Owner: | changed from | to
Priority: | minor → normal |
Type: | defect → enhancement |
Version: | tested |
comment:3 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Pull request with a fix here: https://github.com/JOSM/wikipedia/pull/5