Opened 4 years ago

Last modified 23 months ago

#21725 new defect

Incorrect understanding of lanes=* and *:lanes=* damages data — at Version 2

Reported by: skyper Owned by: Rub21
Priority: critical Milestone:
Component: Plugin turnlanes-tagging Version:
Keywords: template_report lanes count bicycle Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have a way with a cycle lane and complete :lanes-tagging, e.g. w328843875.
    access:lanes=yes|yes|yes|no|yes
    bicycle:lanes=yes|yes|yes|designated|yes
    change:lanes=|||no|no
    cycleway:right=lane
    destination:symbol:lanes=|motorway|motorway||
    highway=primary
    lanes=4
    name=Schreiberstraße
    oneway=yes
    placement=right_of:2
    sidewalk=right
    turn:lanes=left|through|through|through|right
    width:lanes=|||1.8|
    
  2. Open Turn-Lane-tagging-Editor
  3. Close Dialog with OK without changing anything.

What is the expected result?

No changes

What happens instead?

The value of lanes is raised by one.

Please provide any additional information below. Attach a screenshot if possible.

The assumption that lanes[:forward/:backward/:both_ways]=* is always equal to the number of *:lanes[:forward/:backward/:both_ways]=* values is incorrect. It is rather equal or more.
Please take a look at the core validator rules (lanes.java) and #17172.
Additional, to cycle lanes, more :lanes not counting for lanes=* could be present, therefore please, do not rely on bicycle:lanes=*

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-01 23:05:46 +0100 (Mon, 01 Nov 2021)
Revision:18303
Build-Date:2021-11-01 22:25:18
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18303 en) Linux Debian GNU/Linux 11 (bullseye)
Java version: 17.0.1+12-Debian-1deb11u2, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Environment variable LANG: en_US.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME
libcommons-compress-java: libcommons-compress-java:all-1.20-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20201225-1
VM arguments: [-Djosm.home=<josm.pref>]
Dataset consistency test: No problems found

Plugins:
+ tageditor (35640)
+ turnlanes-tagging (288)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Change History (2)

comment:1 by skyper, 4 years ago

Description: modified (diff)

comment:2 by skyper, 4 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.