Opened 15 months ago

Last modified 7 months ago

#21722 new enhancement

[patch] Warn about turning_circle with barrier

Reported by: Famlam Owned by: team
Priority: normal Milestone:
Component: Core validator Version: tested
Keywords: template_report turning_circle barrier Cc:

Description (last modified by Famlam)

What steps will reproduce the problem?

  1. Validate a turning circle with a barrier (few hundred cases worldwide). Example:

What is the expected result?

Warning: if there's a barrier in the middle of the turning_circle, it's a turning_loop; more likely the barrier is directly after leaving the circle and not on the circle, in which case they should be mapped separately.

What happens instead?

No warning

Please provide any additional information below. Attach a screenshot if possible.

Patch: add the following in combinations.mapcss

node[highway=turning_loop][barrier] {
        throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
        group: tr("suspicious tag combination");

(or add the selectors here: )

Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-01 23:05:46 +0100 (Mon, 01 Nov 2021)
Build-Date:2021-11-01 22:25:18
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18303 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19044)
Memory Usage: 533 MB / 1820 MB (166 MB allocated, but free)
Java version: 1.8.0_311-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel:
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: nl_NL
Numbers with default locale: 1234567890 -> 1234567890

+ OpeningHoursEditor (35640)
+ SimplifyArea (35640)
+ imagery_offset_db (35640)
+ pt_assistant (1ff2e15)
+ reverter (35869)
+ tageditor (35640)
+ turnlanes-tagging (288)
+ undelete (35848)
+ utilsplugin2 (35856)

Tagging presets:

Map paint styles:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Last errors/warnings:
- 00012.752 E: Lokaliseren van afbeelding 'bus.png' mislukt

Attachments (0)

Change History (4)

comment:1 Changed 15 months ago by skyper

turning_loop and barrier=* together is wrong, in my eyes, too. Always use an own object for each. Should this be mentioned in the warning?
How about ways?

comment:2 Changed 15 months ago by Famlam

They're wrong indeed, but turning_loops with a barrier are much more rare. I'll add them to the first post anyway.

When they're ways, they cannot be distinguished from "normal" ways (as you wouldn't add highway=turning_loop to ways, just highway=residential or so). For the most unlikely cases of barriers on ways, we already added warnings a few months ago (#20742).

Last edited 7 months ago by Famlam (previous) (diff)

comment:3 Changed 15 months ago by Famlam

Description: modified (diff)

comment:4 Changed 15 months ago by Famlam

Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Famlam
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.