Modify

Opened 2 years ago

Last modified 15 months ago

#21632 new defect

Wrong syntax in hazmat:conditional key

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report conditional hazmat Cc:

Description

What steps will reproduce the problem?

  1. Add key "hazmat:conditional" to a highway
  2. Validate

What is the expected result?

No warning

What happens instead?

Warning.

Please provide any additional information below. Attach a screenshot if possible.

In Sweden is following tag valid:
hazmat:conditional=no @ Th-Mo 15:00-09:00

Revision:18303
Build-Date:2021-11-01 22:53:13

Identification: JOSM/1.5 (18303 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 3914 MB / 4078 MB (1572 MB allocated, but free)
Java version: 17.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 2560×1440 (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_SE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18303, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Program arguments: [%UserProfile%\Documents\OSM\start.jos]
Dataset consistency test: No problems found

Plugins:
+ PicLayer (1.0.1)
+ apache-commons (35524)
+ ejml (35458)
+ geotools (35458)
+ imagery_offset_db (35640)
+ jaxb (35543)
+ jts (35458)
+ measurement (35640)
+ merge-overlap (35640)
+ opendata (35803)
+ reltoolbox (35829)
+ reverter (35846)
+ turnrestrictions (35640)
+ utilsplugin2 (35856)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1

Last errors/warnings:
- 00261.326 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00262.444 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 02899.393 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 05514.322 W: Conflict in data - <html>This relation has been changed outside of the editor.<br>You cannot apply your changes and continue editing.<br><br>Do you want to create a conflict and close the editor?</html>
- 14535.185 E: Error header: Precondition failed: Node 70724409 is still used by ways 9348993.
- 14535.363 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=412, Error Header=<Precondition failed: Node 70724409 is still used by ways 9348993.>
- 14535.367 E: Object still in use - <html><strong>Failed</strong> to delete <strong>node 70724409</strong>. It is still referred to by way 9348993.<br>Please load the way, remove the reference to the node, and upload again.<br><br>Click <strong>Prepare conflict resolution</strong> to load them now.<br>If necessary JOSM will create conflicts which you can resolve in the Conflict Resolution Dialog.</html>
- 14801.197 E: Error header: Precondition failed: Node 1104027260 is still used by ways 95167911.
- 14801.329 E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=412, Error Header=<Precondition failed: Node 1104027260 is still used by ways 95167911.>
- 14801.332 E: Object still in use - <html><strong>Failed</strong> to delete <strong>node 1104027260</strong>. It is still referred to by way 95167911.<br>Please load the way, remove the reference to the node, and upload again.<br><br>Click <strong>Prepare conflict resolution</strong> to load them now.<br>If necessary JOSM will create conflicts which you can resolve in the Conflict Resolution Dialog.</html>

Attachments (0)

Change History (6)

comment:1 by Klumbumbus, 2 years ago

Component: CoreCore validator

comment:2 by skyper, 2 years ago

I think the warning is correct and we need some brackets here: hazmat:conditional=no @ (Th-Mo 15:00-09:00)

comment:3 by skyper, 2 years ago

Maybe one of the following is better:

  • hazmat:conditional=no @ (Th-Su 15:00-24:00, Fr-Mo 00:00-09:00)
  • hazmat:conditional=no @ (Th-Mo 00:00-09:00,15:00-24:00)

comment:4 by MSiipola, 2 years ago

I have tried both suggested alternatives.
But still warnings: Wrong syntax in hazmat:conditional key

comment:5 by skyper, 2 years ago

Ok, according to Conditional_restrictions#By-use_modes hazmat should be used as condition and not as transport mode:
hazmat=no + (motor_)vehicle:conditional=yes @ (Mo-Th 09:00-15:00 AND hazmat).

I am not sure which is correct and we have conflicting content on different OSM wiki pages, again. The current numbers are 2:1 in favor of motor_vehicle.

comment:6 by skyper, 15 months ago

Keywords: conditional hazmat added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to anonymous.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.