Changes between Initial Version and Version 1 of Ticket #21603, comment 4


Ignore:
Timestamp:
2021-11-29T13:35:24+01:00 (4 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #21603, comment 4

    initial v1  
    33Kind of both. There is not `hasInstance` method in JOSM core, so I've got to guess. Elsewhere in the code, I've got something that checks for it, and creates it if it doesn't exist (using reflection).
    44
    5 See https://github.com/JOSM/Mapillary/blob/master/src/main/java/org/openstreetmap/josm/plugins/mapillary/utils/ReflectionUtils.java#L30-L45 for the code I wrote to get around the issue. Which I really need to upstream.
     5~~See https://github.com/JOSM/Mapillary/blob/master/src/main/java/org/openstreetmap/josm/plugins/mapillary/utils/ReflectionUtils.java#L30-L45 for the code I wrote to get around the issue. Which I really need to upstream.~~
     6
     7EDIT: That was for a subcomponent of the ImageViewerDialog. I'll move the code I used to ensure it was created to the `mapFrameInitialized` method in the main plugin class.