Modify ↓

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21541 closed defect (fixed)

false positive: crossing railways

Reported by: dieterdreist Owned by: GerdP
Priority: normal Milestone: 21.12
Component: Core validator Version:
Keywords: railway crossing ways Cc: GerdP

Description

The validator gives a false warning for "crossing railways" when a railway=halt area intersects with a railway=light_rail line (and likely different combinations of other railway types as well).

Attachments (0)

Change History (8)

comment:1 by skyper, 3 years ago

Keywords: railway crossing ways added
Owner: changed from team to dieterdreist
Status: new → needinfo

I do not fully understand the situation you are taking about. Do you have an example.
Additionally, even for trivial looking defects a JOSM version and some more info is appreciated:

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

  • The required parts of the Status Report from your JOSM.
  • Describe what behaviour you expected.
  • Describe what did happen instead.
  • Describe if and how the issue is reproducible.
  • Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Help → source:trunk/resources/images/bug.svg Report Bug.

Remember: This is a generic notice so we don't need to write the same stuff again and again. It may only apply in parts to the specific case!


comment:2 by dieterdreist, 3 years ago

Here is the offending way:
​https://www.openstreetmap.org/way/895453563

my status is:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-09 13:42:26 +0100 (Tue, 09 Nov 2021)
Revision:18321
Build-Date:2021-11-10 02:31:05
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18321 en) Mac OS X 11.5
OS Build number: macOS 11.6 (20G165)
Memory Usage: 1614 MB / 2048 MB (170 MB allocated, but free)
Java version: 16.0.1+9, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: Display 1 1920×1080 (scaling 1.00×1.00) Display 2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_IT
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
+ ColorPlugin (1537115529)
+ Create_grid_of_ways (35640)
+ ImportImagePlugin (35567)
+ PicLayer (1.0.1)
+ apache-commons (35524)
+ buildings_tools (35823)
+ editgpx (35562)
+ ejml (35458)
+ ext_tools (35640)
+ fieldpapers (v0.5.0)
+ geochat (35640)
+ geotools (35458)
+ imagery_offset_db (35640)
+ jts (35458)
+ log4j (35852)
+ mbtiles (v2.6.1)
+ measurement (35640)
+ o5m (35850)
+ pbf (35825)
+ photo_geotagging (35783)
+ poly (35640)
+ reltoolbox (35829)
+ reverter (35846)
+ undelete (35848)
+ utilsplugin2 (35856)

Map paint styles:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip

Last errors/warnings:
- 00023.241 W: Ext_Tools warning: can not load file <josm.userdata>/plugins/ext_tools/tools.cfg
- 00023.247 W: Ext_Tools warning: can not load file <josm.userdata>/plugins/ext_tools/repo.cfg
- 03962.555 W: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server
- 03962.622 E: org.openstreetmap.josm.io.OsmTransferException: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server
- 03962.627 E: Network exception - <html>Failed to open a connection to the remote server<br>'https://api.openstreetmap.org/api/0.6/'.<br>Please check your internet connection.</html>
- 04001.269 W: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server
- 04001.269 W: Already here java.net.SocketException: Unexpected end of file from server
- 04001.327 E: org.openstreetmap.josm.io.OsmTransferException: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server
- 04001.330 E: Network exception - <html>Failed to open a connection to the remote server<br>'https://api.openstreetmap.org/api/0.6/'.<br>Please check your internet connection.</html>


Last edited 3 years ago by skyper (previous) (diff)

comment:3 by skyper, 3 years ago

Cc: GerdP added
Owner: changed from dieterdreist to team
Status: needinfo → new

Thanks,
Ok, we missed that a "train station" without a switch is a railway=halt and it can be drawn a are. railway=halt as area needs to be added to the list of exclusions.

Last edited 3 years ago by skyper (previous) (diff)

comment:4 by GerdP, 3 years ago

Owner: changed from team to GerdP
Status: new → assigned

comment:5 by GerdP, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 18323/josm:

fix #21541: false positive: crossing railways

  • treat railway=halt similar to railway=yard

comment:6 by GerdP, 3 years ago

BTW The wiki ​https://wiki.openstreetmap.org/wiki/Tag:railway%3Dhalt doesn't "allow" the tag railway=halt on ways or relations.

comment:7 by GerdP, 3 years ago

Milestone: → 21.11

comment:8 by Don-vip, 3 years ago

Milestone: 21.11 → 21.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.