Disable Image info when the visualized Geotagged Image is not from mapillary

[bartosomail@…]

The mapillary image info window retains the information of the last visualized mapillary image in the Geotagged Image window, even when the currently visualized image is not from the mapillary layer.

If the add mapillary tag is pressed by mistake when a non mapillary window is visualized, a mapillary tag for an image which doesn't correspond to the one currently visualized will be inserted.

This is most likely an unwanted and undetected result, resulting in wrong information accidentaly entered in OSM. It would be better to prevent those kind of mistakes by disabling the mapillary info when a non mapillary image is visualized.

[taylor.smock]

I'm probably going to have to add a listener to JOSM core in order to fix this properly.

[skyper]

You can switch between layers in geoimage viewer (Ctrl+Alt+J), so the information should be available.

[taylor.smock]

Replying to skyper:

You can switch between layers in geoimage viewer (Ctrl+Alt+J), so the information should be available.

I think the user specifically wants the Mapillary Image Info window to clear when the image viewer is not displaying Mapillary imagery. Which is probably the right thing to do. Either that, or remove the Mapillary Image Info window --

In order to do that, I would either need to (a) check the image viewer every <x> seconds or (b) create some type of listener. I'd prefer to do (b).

Alternatively, I can ensure that all the information visible in the Mapillary Image Info window is shown in the geoimage viewer, and remove Mapillary Image Info.

Data shown and/or copyable in Mapillary Image Info:

• Image detections (count)
  • Also, there is a checkbox to enable/disable the drawing of detections in the image viewer
• Organization name (if available)
• View in browser
  • The link is available in the Copy button. So the user would have to copy/paste the URL
• Copy URL
  • See View in browser
• Add Mapillary tag
  • This is largely a convenience function. Adds mapillary=<image id> to selected object(s)
• Pick Color
  • This is currently broken (due to moving to JOSM Image Viewer). I need to port it over to JOSM. And remove it from the window.
• Image Key
  • There is a copy button for this. I might be able to write a paste intercept function to strip the Mapillary URL from the Copy button.
• Sequence Key

[bartosomail@…]

Replying to taylor.smock:

I think the user specifically wants the Mapillary Image Info window to clear when the image viewer is not displaying Mapillary imagery. Which is probably the right thing to do. Either that, or remove the Mapillary Image Info window --

Exactly, clear the Image info window when the image viewer is not displaying Mapillary imagery.

Closing the Image info window, would also effectively prevent me from accidental insertion of wrong information by means of the Add Mapillary tag functions. But I would find it inconvenient, as I keep switching between layers in the geoimage viewer, and it would be annoying to have to manually reopen the mapillary Image info window every time I select a mapillary image.

Alternatively, I can ensure that all the information visible in the Mapillary Image Info window is shown in the geoimage viewer, and remove Mapillary Image Info.

I like this proposal.

[taylor.smock]

Replying to bartosomail@…:

Closing the Image info window, would also effectively prevent me from accidental insertion of wrong information by means of the Add Mapillary tag functions. But I would find it inconvenient, as I keep switching between layers in the geoimage viewer, and it would be annoying to have to manually reopen the mapillary Image info window every time I select a mapillary image.

OK. I'm going to have to write something for the image display class, and most likely the image entry classes as well.

Probably something like getExtraFunctions or something.

It is good to know that someone is using the Add Mapillary tag button, so I know I shouldn't remove it. :)

[taylor.smock]

This should be fixed in ​f8ddd78632f959f3f42e63e962d360d15ee4dce1.

[bartosomail@…]

It doesn't seem fixed to me.

What I notice is that the "Add Mapillary tag" button in the "Image info" pane is always disabled, even when the selected geotagged image is a mapillary image.

Furthermore, when I select a geotagged image from a different layer, the information of the previously selected mapillary image is retained in the "Image info" pane. The "Add Mapillary tag" is disabled, which is fine in this case.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-01-26 20:13:22 +0100 (Wed, 26 Jan 2022)
Revision:18366
Build-Date:2022-01-27 02:31:08
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18366 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19044)
Memory Usage: 1266 MB / 4068 MB (523 MB allocated, but free)
Java version: 17.0.1+12-LTS-39, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 3840×2160 (scaling 2.50×2.50)
Maximum Screen Size: 3840×2160
Best cursor sizes: 16×16→64×64, 32×32→64×64
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-beta.1)
+ QuickLabel (23)
+ SimplifyArea (35893)
+ apache-commons (35893)
+ apache-http (35893)
+ editgpx (35893)
+ ejml (35893)
+ jaxb (35893)
+ jna (35893)
+ jts (35893)
+ measurement (35893)
+ merge-overlap (35893)
+ photo_geotagging (35893)
+ photoadjust (35893)
+ reltoolbox (35893)
+ reverter (35893)
+ rex (53)
+ undelete (35893)

Tagging presets:
+ D:\OSM\JOSM\presets\cai_josm_preset-master\cai.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Mountains&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/CH.zip
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1

Last errors/warnings:
- 00000.516 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.518 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00087.994 E: Region [mapillary:image:fullImage_BLOCK_v2] : Problem storing keys.
- 00090.179 W: Listener not found for URL: https://scontent-mxp1-1.xx.fbcdn.net/m1/v/t6/An9Y2af1Nke17A-XdxdLUTBpsriOgyg7UwuXofOclivVMdmDC2yFXYLE8qjYOgOdPjwivFeY7TV5nSVjqDjgihj_-GqgYhPJy8z8s74-Uk7sDH4zQbc94EGVfW4Xtq9DMekhVyI6hsW_W-IrzFdSkQ?stp=s2048x1536&ccb=10-5&oh=00_AT9yh7ds67qh_aBAZWaEiLI9Vf-0bRjneclC-xev_FFzyQ&oe=61F68814&_nc_sid=122ab1. Listener not notified!

[taylor.smock]

The problem is that I've got to add a listener to the image viewer. That button should reactivate after a few moments -- it kind of depends upon the updateEnabled method being called, which isn't instant.

Right now, I haven't had the time to do that, and when I do, its going to be a few months before I implement it in the plugin (I want to give people time to upgrade JOSM, while not having to worry about doing a hotfix for an earlier JOSM version -- I've done this with another plugin, and it isn't fun).

[bartosomail@…]

I just now noted that even if the "Add Mapillary tag" button sometimes remains disabled on a mapillary image, it immediately becomes enabled as soon as an object from the image layer is selected (which is always needed anyway to apply a mapillary tag).
So, for all practical purposes, nothing needs to be fixed.