Modify

Opened 3 months ago

Last modified 2 months ago

#21530 new enhancement

Disable Image info when the visualized Geotagged Image is not from mapillary

Reported by: bartosomail@… Owned by: taylor.smock
Priority: normal Milestone:
Component: Plugin mapillary Version: latest
Keywords: Cc:

Description

The mapillary image info window retains the information of the last visualized mapillary image in the Geotagged Image window, even when the currently visualized image is not from the mapillary layer.

If the add mapillary tag is pressed by mistake when a non mapillary window is visualized, a mapillary tag for an image which doesn't correspond to the one currently visualized will be inserted.

This is most likely an unwanted and undetected result, resulting in wrong information accidentaly entered in OSM. It would be better to prevent those kind of mistakes by disabling the mapillary info when a non mapillary image is visualized.

Attachments (0)

Change History (5)

comment:1 Changed 3 months ago by taylor.smock

I'm probably going to have to add a listener to JOSM core in order to fix this properly.

comment:2 Changed 3 months ago by skyper

You can switch between layers in geoimage viewer (Ctrl+Alt+J), so the information should be available.

comment:3 in reply to:  2 ; Changed 3 months ago by taylor.smock

Replying to skyper:

You can switch between layers in geoimage viewer (Ctrl+Alt+J), so the information should be available.

I think the user specifically wants the Mapillary Image Info window to clear when the image viewer is not displaying Mapillary imagery. Which is probably the right thing to do. Either that, or remove the Mapillary Image Info window --

In order to do that, I would either need to (a) check the image viewer every <x> seconds or (b) create some type of listener. I'd prefer to do (b).

Alternatively, I can ensure that all the information visible in the Mapillary Image Info window is shown in the geoimage viewer, and remove Mapillary Image Info.

Data shown and/or copyable in Mapillary Image Info:

  • Image detections (count)
    • Also, there is a checkbox to enable/disable the drawing of detections in the image viewer
  • Organization name (if available)
  • View in browser
    • The link is available in the Copy button. So the user would have to copy/paste the URL
  • Copy URL
    • See View in browser
  • Add Mapillary tag
    • This is largely a convenience function. Adds mapillary=<image id> to selected object(s)
  • Pick Color
    • This is currently broken (due to moving to JOSM Image Viewer). I need to port it over to JOSM. And remove it from the window.
  • Image Key
    • There is a copy button for this. I might be able to write a paste intercept function to strip the Mapillary URL from the Copy button.
  • Sequence Key

comment:4 in reply to:  3 ; Changed 3 months ago by bartosomail@…

Replying to taylor.smock:

I think the user specifically wants the Mapillary Image Info window to clear when the image viewer is not displaying Mapillary imagery. Which is probably the right thing to do. Either that, or remove the Mapillary Image Info window --

Exactly, clear the Image info window when the image viewer is not displaying Mapillary imagery.

Closing the Image info window, would also effectively prevent me from accidental insertion of wrong information by means of the Add Mapillary tag functions. But I would find it inconvenient, as I keep switching between layers in the geoimage viewer, and it would be annoying to have to manually reopen the mapillary Image info window every time I select a mapillary image.

Alternatively, I can ensure that all the information visible in the Mapillary Image Info window is shown in the geoimage viewer, and remove Mapillary Image Info.

I like this proposal.

comment:5 in reply to:  4 Changed 2 months ago by taylor.smock

Replying to bartosomail@…:

Closing the Image info window, would also effectively prevent me from accidental insertion of wrong information by means of the Add Mapillary tag functions. But I would find it inconvenient, as I keep switching between layers in the geoimage viewer, and it would be annoying to have to manually reopen the mapillary Image info window every time I select a mapillary image.

OK. I'm going to have to write something for the image display class, and most likely the image entry classes as well.

Probably something like getExtraFunctions or something.

It is good to know that someone is using the Add Mapillary tag button, so I know I shouldn't remove it. :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain taylor.smock.
as The resolution will be set.
to The owner will be changed from taylor.smock to the specified user.
The owner will change to bartosomail@yahoo.it
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from taylor.smock to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.