Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21508 closed enhancement (fixed)

[Patch] Remove empty rows from multiselect

Reported by: skyper Owned by: team
Priority: normal Milestone: 21.12
Component: Internal preset Version:
Keywords: empty rows multiselect Cc:

Description (last modified by skyper)

After r18254, we can revert parts of r16482, see #19013.

Please find attached patch which adds the exact number of rows for <multiselect /> with less than eight rows.

Attachments (1)

josm_21508.patch (6.0 KB ) - added by skyper 3 years ago.
patch

Download all attachments as: .zip

Change History (7)

by skyper, 3 years ago

Attachment: josm_21508.patch added

patch

comment:1 by skyper, 3 years ago

Description: modified (diff)

comment:2 by skyper, 3 years ago

Milestone: 21.11

comment:3 by GerdP, 3 years ago

Why is it needed to add a count which is equal to the number of items? I would expect this to be the default (at least for short lists)

Last edited 3 years ago by GerdP (previous) (diff)

comment:4 by Don-vip, 3 years ago

Resolution: fixed
Status: newclosed

In 18307/josm:

fix #21508 - Remove empty rows from multiselect (patch by skyper)

in reply to:  3 comment:5 by skyper, 3 years ago

Replying to GerdP:

Why is it needed to add a count which is equal to the number of items? I would expect this to be the default (at least for short lists)

Please, go ahead. So far, the default is a fixed number, 8, and numbers of values are not checked at all. Maybe, some users like to even change the default value.

comment:6 by Don-vip, 3 years ago

Milestone: 21.1121.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.