Modify ↓

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21447 closed enhancement (fixed)

[Patch] layer=0 proposed in presets, then warned about

Reported by: Famlam Owned by: team
Priority: minor Milestone: 21.12
Component: Internal preset Version: latest
Keywords: layer 0 Cc: skyper

Description

Followup of https://josm.openstreetmap.de/ticket/21426#comment:6

defaultspresets contains 22 instances of layer tags being proposed. Each is of the form (with or without default):

<combo key="layer" text="Layer" values="5,4,3,2,1,0,-1,-2,-3,-4,-5" length="3" values_sort="false" />

However, the validator will complain about layer=0.

Simple proposal:
remove 0 as layer value in the preset

Attachments (1)

josm_21447.patch​ (13.0 KB ) - added by skyper 3 years ago.
patch

Download all attachments as: .zip

Change History (4)

by skyper, 3 years ago

Attachment: josm_21447.patch​ added

patch

comment:1 by skyper, 3 years ago

Keywords: 0 added
Milestone: → 21.11
Summary: layer=0 proposed in presets, then warned about → [Patch] layer=0 proposed in presets, then warned about

Please, find attached patch​ which removes 0 from the offered values. It already includes the fix for #21610.

comment:2 by Klumbumbus, 3 years ago

Resolution: → fixed
Status: new → closed

In 18326/josm:

fix #21447, fix #21610, see #21426 - remove layer=0 from presets and fix default layer=-1 to layer=1 for man_made=bridge (patch by skyper)

comment:3 by Don-vip, 3 years ago

Milestone: 21.11 → 21.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.