Opened 4 years ago
Closed 11 months ago
#21409 closed enhancement (fixed)
NewTags: Add man_made=flare
Reported by: | gaben | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | External preset | Version: | |
Keywords: | NewTags man_made flare | Cc: | francois.lacombe |
Description
The Tag:man_made=flare tagging is not yet established I think, but a suitable icon was created by francois.lacombe in #20530.
Attachments (0)
Change History (11)
comment:1 by , 4 years ago
comment:2 by , 4 years ago
Component: | Core → External preset |
---|---|
Keywords: | NewTags man_made=flare added |
Summary: | Add man_made=flare icon → NewTags: Add man_made=flare |
comment:4 by , 3 years ago
I was not happy with the icon and my results trying to enhance it.
Yes, all "external" are either located on our wiki or on completely different system. Changes on our wiki are made at the corresponding wiki page and the rest (creating the files, updating the lists) is automatically done in background.
comment:5 by , 3 years ago
I added the flare, but without an icon for now. Hopefully didn't break it.
follow-up: 7 comment:6 by , 3 years ago
It works, so the next is the icon. The icon from #20530 is a good starting point. Would you do something like OsmAnd
does?
comment:7 by , 3 years ago
Replying to gaben:
It works, so the next is the icon. The icon from #20530
is a good starting point. Would you do something like OsmAnd
does?
For external presets' icons the requirement is much lower than for core, especially, if they are not used for mappaint styles. Regarding the different LaFs, colorful icons with contrasts are still better than only black (one color) and white.
Actually, I thought we are talking about one of these icons:
The files should be in josm_20530_new_pump_icons.tar.xz:ticket:20530.
comment:8 by , 3 years ago
Sorry, I forgot about these. Just note, the flare is gas only, so a single icon is enough.
Regarding the OsmAnd icon, I looked at just the subject geometry, color is the easiest to change.
comment:11 by , 11 months ago
Keywords: | man_made flare added; man_made=flare removed |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Thank you!
Fixed in Presets/NewTags?version=126.
Actually, I changed the icon in #20530 a little bit. Anyway, I would remove the right part and only use a mast with a flame on top.
We store unused icons under browser/josm/trunk/resources/nodist/images/.
In this case, the best solution would be to add
man_made=flare
to Presets/NewTags.