Modify

Opened 4 years ago

Closed 11 months ago

#21409 closed enhancement (fixed)

NewTags: Add man_made=flare

Reported by: gaben Owned by: team
Priority: normal Milestone:
Component: External preset Version:
Keywords: NewTags man_made flare Cc: francois.lacombe

Description

The Tag:man_made=flare tagging is not yet established I think, but a suitable icon was created by francois.lacombe in #20530.

Attachments (0)

Change History (11)

comment:1 by skyper, 4 years ago

Actually, I changed the icon in #20530 a little bit. Anyway, I would remove the right part and only use a mast with a flame on top.

We store unused icons under browser/josm/trunk/resources/nodist/images/.

In this case, the best solution would be to add man_made=flare to Presets/NewTags.

comment:2 by skyper, 4 years ago

Component: CoreExternal preset
Keywords: NewTags man_made=flare added
Summary: Add man_made=flare iconNewTags: Add man_made=flare

comment:3 by gaben, 3 years ago

I need just edit the file there and done?

comment:4 by skyper, 3 years ago

I was not happy with the icon and my results trying to enhance it.

Yes, all "external" are either located on our wiki or on completely different system. Changes on our wiki are made at the corresponding wiki page and the rest (creating the files, updating the lists) is automatically done in background.

comment:5 by gaben, 3 years ago

I added the flare, but without an icon for now. Hopefully didn't break it.

comment:6 by gaben, 3 years ago

It works, so the next is the icon. The icon from #20530 Icon for man_made=petroleum_well is a good starting point. Would you do something like OsmAnd https://raw.githubusercontent.com/osmandapp/OsmAnd-resources/4f5d13b308eddcd40ead5220a9046f89bebdcf02/icons/svg/poi_colored/flare.svg does?

in reply to:  6 comment:7 by skyper, 3 years ago

Replying to gaben:

It works, so the next is the icon. The icon from #20530 Icon for man_made=petroleum_well is a good starting point. Would you do something like OsmAnd https://raw.githubusercontent.com/osmandapp/OsmAnd-resources/4f5d13b308eddcd40ead5220a9046f89bebdcf02/icons/svg/poi_colored/flare.svg does?

For external presets' icons the requirement is much lower than for core, especially, if they are not used for mappaint styles. Regarding the different LaFs, colorful icons with contrasts are still better than only black (one color) and white.

Actually, I thought we are talking about one of these icons:
icons casing light bg icons casing black bg

The files should be in josm_20530_new_pump_icons.tar.xz:ticket:20530.

comment:8 by gaben, 3 years ago

Sorry, I forgot about these. Just note, the flare is gas only, so a single icon is enough.

Regarding the OsmAnd icon, I looked at just the subject geometry, color is the easiest to change.

comment:9 by gaben, 11 months ago

Cc: francois.lacombe added

@francois, can I use your icon in Presets/NewTags?

comment:10 by francois.lacombe, 11 months ago

Hello @gaben
Yes of course, my pleasure!

comment:11 by gaben, 11 months ago

Keywords: man_made flare added; man_made=flare removed
Resolution: fixed
Status: newclosed

Thank you!

Fixed in Presets/NewTags?version=126.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.